-
Notifications
You must be signed in to change notification settings - Fork 25
Add guideline for claude to avoid repeating existing comments #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Claude frequently repeats itself in comments, especially on subsequent pushes. This attempts to stop that by instructing it to not repeat existing comments.
|
Claude finished @quexten's task —— View job Code Review Complete ✅Tasks
Summary of ChangesThis PR adds a single guideline to the Claude code review prompt template ( Modified File:
Critical IssuesNone identified. This is a straightforward documentation change with no code impact. Suggested ImprovementsOptional enhancements for future consideration
Good Practices Observed
Action ItemsNone required. The change is ready to merge as-is. The suggested improvements above are optional enhancements that could be considered in future iterations if the current guideline proves insufficient. Verdict: ✅ APPROVED - This is a sensible improvement to the Claude code review prompt that should reduce redundant comments in subsequent review iterations. |
|
Great job! No new security vulnerabilities introduced in this pull request |
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #607 +/- ##
=======================================
Coverage 78.67% 78.67%
=======================================
Files 283 283
Lines 29285 29285
=======================================
Hits 23041 23041
Misses 6244 6244 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
withinfocus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this unnecessary since we are trying to fix this in the Action invocation?
|
@withinfocus This was opened before starting the thread on it / before the other PR was opened. Closing this now as it is superseeded by bitwarden/gh-actions#517 |

🎟️ Tracking
📔 Objective
Claude frequently repeats itself in comments, especially on subsequent pushes. This attempts to stop that by instructing it to not repeat existing comments.
🚨 Breaking Changes
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes