Skip to content

Conversation

@quexten
Copy link
Contributor

@quexten quexten commented Dec 11, 2025

🎟️ Tracking

📔 Objective

Claude frequently repeats itself in comments, especially on subsequent pushes. This attempts to stop that by instructing it to not repeat existing comments.

🚨 Breaking Changes

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation
    team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed
    issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Claude frequently repeats itself in comments, especially on subsequent pushes. This attempts to stop that by instructing it to not repeat existing comments.
@quexten quexten marked this pull request as ready for review December 11, 2025 14:32
@quexten quexten requested a review from a team as a code owner December 11, 2025 14:32
@quexten quexten changed the title Add guideline to avoid repeating existing comments Add guideline for claude to avoid repeating existing comments Dec 11, 2025
@claude
Copy link

claude bot commented Dec 11, 2025

Claude finished @quexten's task —— View job


Code Review Complete ✅

Tasks

  • Gather context about the PR changes
  • Review the modified file
  • Analyze changes with code reviewer
  • Provide review feedback

Summary of Changes

This PR adds a single guideline to the Claude code review prompt template (.claude/prompts/review-code.md:25) to explicitly instruct the AI reviewer not to repeat existing comments when reviewing subsequent commits.

Modified File:

  • .claude/prompts/review-code.md - Added "- Do not repeat existing comments" to the "When reviewing subsequent commits:" section

Critical Issues

None identified. This is a straightforward documentation change with no code impact.

Suggested Improvements

Optional enhancements for future consideration
  1. Consider additional context specificity - The guideline could be enhanced to clarify what constitutes "repeating" a comment:

    • "Do not repeat existing inline comments on the same lines unless the issue has changed"
    • "Reference previous comment threads instead of reposting the same observations"
  2. Placement consideration - While well-placed, you might consider adding a note about how to reference existing comments (e.g., "If an issue persists, reference the existing comment thread rather than creating a duplicate").

Good Practices Observed

  • Clear, concise guideline addition properly placed within relevant section context
  • Commit message clearly explains the motivation

Action Items

None required. The change is ready to merge as-is. The suggested improvements above are optional enhancements that could be considered in future iterations if the current guideline proves insufficient.


Verdict:APPROVED - This is a sensible improvement to the Claude code review prompt that should reduce redundant comments in subsequent review iterations.


@github-actions
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsf39daafb-c0d8-42a5-ba76-c0fc3d5b3c19

Great job! No new security vulnerabilities introduced in this pull request

@github-actions
Copy link
Contributor

github-actions bot commented Dec 11, 2025

🔍 SDK Breaking Change Detection Results

SDK Version: claude-dry (525226e)
Completed: 2025-12-11 14:43:01 UTC
Total Time: 249s

Client Status Details
typescript ✅ No breaking changes detected TypeScript compilation passed with new SDK version - View Details

Breaking change detection completed. View SDK workflow

@codecov
Copy link

codecov bot commented Dec 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.67%. Comparing base (30879c1) to head (525226e).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   78.67%   78.67%           
=======================================
  Files         283      283           
  Lines       29285    29285           
=======================================
  Hits        23041    23041           
  Misses       6244     6244           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@withinfocus withinfocus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this unnecessary since we are trying to fix this in the Action invocation?

@quexten
Copy link
Contributor Author

quexten commented Dec 12, 2025

@withinfocus This was opened before starting the thread on it / before the other PR was opened. Closing this now as it is superseeded by bitwarden/gh-actions#517

@quexten quexten closed this Dec 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants