bw-auth - Add uniffi support #609
Conversation
JaredSnider-Bitwarden
requested review from
Patrick-Pimentel-Bitwarden and
addisonbeck
|
Claude finished @JaredSnider-Bitwarden's task —— View job Code Review CompleteTasks:
Review SummaryThe bitwarden-code-reviewer agent has completed a thorough review of this PR and posted inline comments directly on the code. Overall Assessment: MAJOR CONCERNS - Missing UniFFI Attributes While the UniFFI scaffolding and configuration are correctly implemented, the PR is incomplete. Several public structs and enums in the Critical IssuesMissing UniFFI attributes on public request types in The following publicly exported types need
These types are publicly exported and used in the public API ( What Was Done Correctly ✅
Required ChangesAdd the missing attributes to #[cfg_attr(feature = "uniffi", derive(uniffi::Record))]
pub struct SendPasswordCredentials { ... }
#[cfg_attr(feature = "uniffi", derive(uniffi::Record))]
pub struct SendEmailCredentials { ... }
#[cfg_attr(feature = "uniffi", derive(uniffi::Record))]
pub struct SendEmailOtpCredentials { ... }
#[cfg_attr(feature = "uniffi", derive(uniffi::Enum))]
#[serde(untagged)]
pub enum SendAccessCredentials { ... }
#[cfg_attr(feature = "uniffi", derive(uniffi::Record))]
pub struct SendAccessTokenRequest { ... }Verification: cargo check --features uniffi -p bitwarden-auth
cargo build --features uniffi -p bitwarden-authRecommendation: Request changes - the missing attributes will cause issues when mobile clients try to use these types. |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| [bindings.swift] | ||
| ffi_module_name = "BitwardenAuthFFI" | ||
| module_name = "BitwardenAuth" | ||
| generate_immutable_records = true No newline at end of file |
There was a problem hiding this comment.
Missing trailing newline: This file should end with a newline character to match repository conventions. Most editors add this automatically, and it's a common git best practice.
|
Great job! No new security vulnerabilities introduced in this pull request |
🔍 SDK Breaking Change Detection ResultsSDK Version:
Breaking change detection completed. View SDK workflow |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #609 +/- ##
==========================================
- Coverage 78.57% 78.57% -0.01%
==========================================
Files 283 283
Lines 29187 29188 +1
==========================================
Hits 22934 22934
- Misses 6253 6254 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Patrick-Pimentel-Bitwarden
left a comment
Patrick-Pimentel-Bitwarden
left a comment
There was a problem hiding this comment.
👍 Approving with my limited rust knowledge, but following a conversation with Jared it sounds like the correct boxes have been ticked for being done correctly.
🎟️ Tracking
n/a but blocks #549 and #596
📔 Objective
To add UNIFFI support to the bw-auth crate
⏰ Reminders before review
team
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmedissue and could potentially benefit from discussion
:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes