Skip to content

Do not set authorization headers if access key id or secret access key is NULL #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mpartio wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not set authorization headers if access key id or secret access key is NULL #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/request.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,6 +982,13 @@ static S3Status compose_auth_header(const RequestParams *params,
printf("--\nCanonical Request:\n%s\n", canonicalRequest);
#endif

if (params->bucketContext.accessKeyId == NULL || params->bucketContext.secretAccessKey == NULL) {
#ifdef SIGNATURE_DEBUG
printf("--\nNo authorization header\n");
#endif
return S3StatusOK;
}

len = 0;
unsigned char canonicalRequestHash[S3_SHA256_DIGEST_LENGTH];
#ifdef __APPLE__
Expand Down