default sass vars + DOMContentLoaded "bugfix" by strajk#17
Open
pouipouidesign wants to merge 4 commits intobjork24:masterfrom
Open
default sass vars + DOMContentLoaded "bugfix" by strajk#17pouipouidesign wants to merge 4 commits intobjork24:masterfrom
pouipouidesign wants to merge 4 commits intobjork24:masterfrom
Conversation
Doesn't seem to be breaking anything, so let's incorporate it.
adding " !default" to each variable declaration otherwise you can't easily override them in your own sass variables file
There was a problem hiding this comment.
Does this `!default~ have to be split across usn-large, usn-large-medium, et al? Or does just putting it here apply it to all?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
First, thanks for the really cool work :)
My modest "contribution", not very used to pull requests... but I track your plugin with bower and fear I'll forget I modified your file, update it and loose my mods...
Hope this is useful to you, and thanks again for the great work!