Skip to content

feat(_oak2_mods): add BL4ItemSpawner mod#153

Closed
Cr4nkSt4r wants to merge 2 commits intobl-sdk:masterfrom
Cr4nkSt4r:master
Closed

feat(_oak2_mods): add BL4ItemSpawner mod#153
Cr4nkSt4r wants to merge 2 commits intobl-sdk:masterfrom
Cr4nkSt4r:master

Conversation

@Cr4nkSt4r
Copy link
Copy Markdown

No description provided.

@apple1417
Copy link
Copy Markdown
Contributor

Mostly looks good, the only thing I do need to ask you to change is add requirements via the standard project.dependencies field. But also blimgui isn't in this repo yet - idk what happened with that - and I can't really merge a mod pointing at a dependency that doesn't exist yet, that will really confuse users. I'll just leave the pr open

An extra suggestion I will make though: you're currently overwriting a couple fields when you call build_mod. One of the ideas behind it pulling from the pyproject was you could have a single source of truth - which'd avoid copy paste errors like how your pyproject says unknown coop support, but in game you say client side.

@Cr4nkSt4r Cr4nkSt4r closed this Apr 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants