This repository was archived by the owner on Jun 22, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 31
Removed tilde from asset paths, update to differentiate between CSS and template files #1080
Open
Blackbaud-AlexKingman
wants to merge
9
commits into
master
Choose a base branch
from
assets-path-remove-tilde
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
127b4b0
Removed tilde from asset paths
90e2555
using absolute
2cf3398
Merge branch 'master' into assets-path-remove-tilde
blackbaud-johnly da07551
updated to reflect document vs root-relative paths
d1e7b2e
Merge branch 'master' into assets-path-remove-tilde
6e00b42
Merge branch 'assets-path-remove-tilde' of https://github.com/blackba…
8e35df5
Merge branch 'master' into assets-path-remove-tilde
Blackbaud-AlexKingman db1cf51
Update src/app/learn/get-started/advanced/include-static-assets/index…
Blackbaud-AlexKingman de45338
Update src/app/learn/get-started/advanced/include-static-assets/index…
Blackbaud-AlexKingman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need an initial step like in the previous section telling users to store the statics asset in
src/assets? The example here is still using/assets/img/, so it seems like they'd still need to add the image to that folder path.