Multiruntime pool warning (revert #387)#389
Open
davidrjonas wants to merge 2 commits intoblackbeam:masterfrom
Open
Multiruntime pool warning (revert #387)#389davidrjonas wants to merge 2 commits intoblackbeam:masterfrom
davidrjonas wants to merge 2 commits intoblackbeam:masterfrom
Conversation
…ntime support" This reverts commit 1fe2adb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I must apologize for my premature PR (#387). It was incorrect.
Although it fixed the "Pool was disconnected" problem, some connections still got the "A Tokio 1.x context was found, but it is being shutdown." Further debugging found that the I/O driver for the
TcpStreamstays with the runtime where the connection was started. And there doesn't seem to be any way around that. I don't think Pool is safe to share in a multi-runtime environment like actix-web. One Pool per worker works great, though it's more work to collect metrics.I've reverted my previous commit and added a short section to the Pool documentation that warns about the situation.
Thanks for your patience!