Add support of a custom executor

[blackbeam]

This PR adds support of a custom executors (defaults to tokio::executor::DefaultExecutor).

Required bounds for supported executors are defined as MyExecutor trait.

New constructors:

• Conn::with_executor
• Conn::from_url_with_executor
• Pool::with_executor
• Pool::from_url_with_executor

Changes to existing code should be minimal because of default value for new type parameter on Pool and Conn.

[blackbeam]

@PvdBerg1998, could you please test this branch with your executor?

[PvdBerg1998]

Looks great! I'll test it now.

[PvdBerg1998]

I have a question: what happens when the Pool is dropped? Are existing connections dropped immediately? Because requiring the Executor in drop would mean trouble for my usecase and I think it's weird to do so. Or are the connections only cleaned up when manually calling disconnect?

[PvdBerg1998]

The same concern I have about this function:

mysql_async/src/conn/mod.rs

Line 39 in 7a978e6

fn disconnect<E: crate::MyExecutor>(mut conn: Conn<E>) {

Also, this still is hardcoded to use tokio.

Edit: I think the disconnection should just be done in a blocking way inside Drop.

[PvdBerg1998]

I found something weird: my process does not exit after main finishes? Details:

1. The executor is halted, so it will fail to spawn a future.
2. The database pool is dropped at the end of main
3. Perhaps something is waiting forever inside a drop impl?

[PvdBerg1998]

I found the issue: I have a wrapping type around a Pool, with a Drop impl that does this:

let _ = block_on(self.pool.clone().disconnect().compat());

Apparently this blocks forever when the executor is halted. Any idea how this could be prevented?

[PvdBerg1998]

@blackbeam I would really like to fix this issue. Just fyi the PR most likely breaks something (or, hopefully, I'm doing something wrong) so it shouldn't be merged yet. If we wait until async await is stable and tokio is updated, I can move back to using tokio and this is no longer an issue. Still it is a nice flexibility feature but I expect tokio to get used most of the time