Fix WKWebView crash on tab close #119
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix WKWebView crash on tab close
Problem
When closing a WKWebView tab, the app crashes with signal 11 (SIGSEGV).
Root Cause
dispatch_asyncblock, causing a use-after-freedealloc, but by thenself.webViewwas already nilSolution
deallocfor already-removed observersTesting
Tested by repeatedly opening and closing both CEF and WebKit tabs - no more crashes.