bug fix: label rotation not working at +90 and -90 deg.#172
Open
praveenvitara wants to merge 1 commit intoblacklabel:masterfrom
Open
bug fix: label rotation not working at +90 and -90 deg.#172praveenvitara wants to merge 1 commit intoblacklabel:masterfrom
praveenvitara wants to merge 1 commit intoblacklabel:masterfrom
Conversation
Collaborator
|
Thank you for the PR! Could you create a demo that shows what is broken? Exactly the same code is used in the core for labels. I'm afraid the solution you implemented won't work in many other scenarios, for example 45deg, 30deg, 15deg etc. I think we should use real width, not the text length (as variable name suggests), because it's used to calculate required space for Axis to fit in all category names (or alternatively apply ellipsis or word wrapping). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
textPxLength is taken based on label orientation, fixes issues with autoRotation and rotation at 90 and -90 deg.
while rendering axis, labels are initially created horizontally and moved and rotated at the later stages in which autoRotation and rotation for 90 deg is failing to apply due to invalid textPxLength, which is previously taken from label width.