Fix factory function not working in nodejs environment#226
Open
windmichael wants to merge 1 commit intoblacklabel:masterfrom
Open
Fix factory function not working in nodejs environment#226windmichael wants to merge 1 commit intoblacklabel:masterfrom
windmichael wants to merge 1 commit intoblacklabel:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This library is currently not working on a NodeJs environment.
This leads to the issue that Jest Tests will fail, because Jest is running on NodeJs.
A workaround to get tests on components running where this Library is used, is to completely mock this library. But to find the root cause, why the tests failed and to implement a workaround therefore took me some hours.
The error you get when running this library on a node environment is that the default function is not available.
I checked how other libraries are implemented and found that the factory function needs to be assigned to the "default" property.
Same as here: https://github.com/blacklabel/custom_events/blob/master/js/customEvents.js
If you could merge this PR this would probably help other Devs to save some time and not running into this issue.