Fixed #220, Rendering nested categories properly when Sampling Starts#237
Open
nithin4048-1 wants to merge 2 commits intoblacklabel:masterfrom
Open
Fixed #220, Rendering nested categories properly when Sampling Starts#237nithin4048-1 wants to merge 2 commits intoblacklabel:masterfrom
nithin4048-1 wants to merge 2 commits intoblacklabel:masterfrom
Conversation
Author
|
Hi @pawelfus / @jedrzejruta , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before fix recording:
https://github.com/user-attachments/assets/db0f0b7d-06cb-4483-9073-8075f6355fcb
After fix recording:
https://github.com/user-attachments/assets/7ed43c3b-00c7-4ff1-9d2e-4048b7651787
Fixes covered as part of this PR:
Leaf labels follow Highcharts native overlap behavior -> Previously, the plugin forced all leaf (x-axis) labels to display, causing them to overlap each other on dense charts. Now Highcharts handles label visibility natively, automatically hiding overlapping labels just like it does on a standard axis.
Text truncation with ellipsis for parent labels -> When there isn't enough horizontal space for a parent category label, the text is now truncated with an ellipsis ("...") instead of overflowing or overlapping adjacent labels. Labels are hidden entirely when the space is extremely tight and restored automatically when the chart is resized wider.
Grid lines no longer break on narrow charts with many bars -> Previously, when the chart was narrow and had dense data, grid separator lines would go missing or render incorrectly. This has been fixed.
Corrected grid positioning across all levels -> Grid lines for both leaf-level and parent-level separators were misaligned. Their positioning has been corrected so they render accurately at every depth.
Accurate parent grid separator placement -> Parent-level grid separators are now positioned based on the actual category tree structure rather than relying on rendered tick data, which could be incomplete when Highcharts hides labels. This ensures separators always appear at the correct boundaries.
Improved leaf label vertical centering -> Leaf labels are better centered within their grid row on grouped axes, while still respecting any custom distance set by the user.