Skip to content

Fixed rendering chart with dataLabels disabled #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
annavvis wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixed rendering chart with dataLabels disabled #6

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c5c39c4
Fixed #5, the chart didn't render without dataLabels enabled.
annavvis Apr 23, 2026
518864a
Added type for when dataLabels is an array. Updated condition.
annavvis Apr 23, 2026
9a5ca51
Added regression test.
annavvis Apr 24, 2026
78b1d5a
Update fix to use H.splat, remove test.
annavvis Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion js/ternary-plot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,13 @@ function TernaryPlotPlugin(H) {
e.isInsidePlot = pointInTriangle(px, py, Ax, Ay, Bx, By, Cx, Cy);
});
addEvent(Series, 'afterDrawDataLabels', function () {
if (!(this.options.minSize && this.options.maxSize)) {
// Data labels can be enabled either as a single object or as an array
// of objects (#5)
const dataLabelsOption = this.options.dataLabels;
const dataLabelsEnabled = dataLabelsOption === undefined
? true
: H.splat(dataLabelsOption).some(d => (d === null || d === void 0 ? void 0 : d.enabled) !== false);
if (!(this.options.minSize && this.options.maxSize) || !dataLabelsEnabled) {
return;
}
this.points.forEach(point => {
Expand Down
10 changes: 9 additions & 1 deletion ts/ternary-plot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,7 @@ type TernarySeriesOptions = Highcharts.SeriesOptions & {
minSize?: number;
maxSize?: number;
componentColors?: ComponentColors;
dataLabels?: Highcharts.DataLabelsOptions | Highcharts.DataLabelsOptions[];
};

type TernarySeries = Highcharts.Series & {
Expand Down Expand Up @@ -1071,7 +1072,14 @@ export default function TernaryPlotPlugin(H: HighchartsPlugin): void {
});

addEvent(Series, 'afterDrawDataLabels', function (this: TernarySeries) {
if (!(this.options.minSize && this.options.maxSize)) {
// Data labels can be enabled either as a single object or as an array
// of objects (#5)
const dataLabelsOption = this.options.dataLabels;
const dataLabelsEnabled = dataLabelsOption === undefined
? true
: H.splat(dataLabelsOption).some(d => d?.enabled !== false);

if (!(this.options.minSize && this.options.maxSize) || !dataLabelsEnabled) {
return;
}

Expand Down