-
-
Notifications
You must be signed in to change notification settings - Fork 842
Feature: implementation of jtagtap_cycle() for FTDI backend
#2181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: implementation of jtagtap_cycle() for FTDI backend
#2181
Conversation
|
Please rebase this PR on |
a1fe471 to
74a11ed
Compare
dragonmux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of review notes, nothing too major though and with them addressed we'll be happy to merge this.
|
Your questions made me realize I've designed this with a logic bug, where it commands 0x8e 0xff when 8 clocks are requested; should be 0x8e 0x07 or 0x8f 0x00. Confirmed with a small throwaway unit test snippet. |
4540bd5 to
c4549be
Compare
c4549be to
e4ae916
Compare
e4ae916 to
f9e0169
Compare
dragonmux
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, merging. Thank you for the contribution and this speed-up to the FTDI code for running cycles where TMS and TDI need to be kept constant
Detailed description
jtagtap_cycle()sometimes, but BMDA hasn't always provided it.Tested on FT2232HL against a RISC-V MCU. Based on #2179. See #2180 for tracking other backends.
I would like some explanation, is buffering beneficial in the handlers, or does it exist externally (between two flush calls), then I can discard the 2nd commit.
Your checklist for this pull request
Closing issues