Feature: detect GD32VW553 #2186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonmux
requested changes
Feb 2, 2026
Member
dragonmux
left a comment
dragonmux
left a comment
There was a problem hiding this comment.
Only got a couple of relatively small notes. With them addressed, we'll be happy to merge this as this looks great!
src/target/jtag_devs.c
Outdated
| .idmask = 0x0fffffffU, | ||
| #if ENABLE_DEBUG == 1 | ||
| .descr = "RISC-V debug v0.13.", | ||
| .descr = "Andes DTM", |
Member
There was a problem hiding this comment.
We would like to keep the more generic string here, as while this is useful, the generic string pools and thus doesn't take additional space up.. If we do keep this revised string, we would prefer to see something like "Andes Tech RV DTM." - with the . included for consistency with the other entries.
src/target/jtag_devs.c
Outdated
Comment on lines
413
to
421
| .descr = "Andes DTM", | ||
| #endif | ||
| .handler = riscv_jtag_dtm_handler, | ||
| }, | ||
| { | ||
| .idcode = 0x00307a6dU, | ||
| .idmask = 0x0fffffffU, | ||
| #if ENABLE_DEBUG == 1 | ||
| .descr = "Nuclei Systems DTM", |
dragonmux
added
Enhancement
ALTracer
force-pushed
the
feature/gd32vw553
branch
from
ec38a28 to
715795c
Compare
* The value was used internally by BMD as RV_GIGADEVICE, but it does not belong to Gigadevice (SoC vendor) or to Nucleisys (processor vendor). This is visible on JTAG TAP IDCODE of DTM and RISC-V mvendorid CSR of GD32VF103 SoC.
* Proper JEP-106 value of 0xa36 belonging to Nuclei Systems Technology * 307 is related to Nuclei N307 processor core
ALTracer
force-pushed
the
feature/gd32vw553
branch
from
715795c to
a56c174
Compare
dragonmux
approved these changes
Feb 2, 2026
Member
dragonmux
left a comment
dragonmux
left a comment
There was a problem hiding this comment.
LGTM, merging. Thank you for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
Not tested as I don't have that board, only GD32VF103. But going by the logs, it makes sense:
Info : JTAG tap: gd32vw553.cpu tap/device found: 0x10307a6d (mfg: 0x536 (Nuclei System Technology Co Ltd), part: 0x0307, ver: 0x1)Info : JTAG tap: auto0.tap tap/device found: 0x790007a3 (mfg: 0x3d1 (GigaDevice Semiconductor (Beijing)), part: 0x9000, ver: 0x7)There is valuable internal cleanup w.r.t. JTAG and generic RISC-V probe paths. I can discard
gd32vw5_probe()stub, and the weak nop mechanism will simply return false for it.Your checklist for this pull request
Closing issues