flashstub: Fix ELF to hexdump conversion #2188
Open
+46
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragonmux
requested changes
Feb 3, 2026
Member
dragonmux
left a comment
dragonmux
left a comment
There was a problem hiding this comment.
Got only the one review note and with that addressed, we'll be happy to merge this.
| ], | ||
| input: lmi_stub_elf, | ||
| output: 'lmi_stub_bin', | ||
| ) |
Member
There was a problem hiding this comment.
Might as well make this lmi_stub.bin (and so forth for the others) so they have a file extension - but otherwise this looks good.
dragonmux
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detailed description
Meson is currently set up to build hexdumps of entire ELF files instead of just the relevant part of the binary (which is the
.textsection in all cases).This adds an intermediate
objcopyto extract the section in binary format and directs that to thehexdumpstep to produce the correct output.Your checklist for this pull request
Closing issues
None.