Upgrade dependencies, pivot to crypto/sha256 for FIPS 140 compliance#25
Upgrade dependencies, pivot to crypto/sha256 for FIPS 140 compliance#25abhinavdangeti merged 11 commits intomasterfrom
crypto/sha256 for FIPS 140 compliance#25Conversation
There was a problem hiding this comment.
Pull request overview
This PR upgrades project dependencies and performs maintenance tasks including removing legacy code, updating Go version, and fixing repository references.
Changes:
- Updated Go version from 1.21 to 1.24.0 and upgraded all dependencies
- Added modern
//go:builddirectives alongside legacy+buildtags - Fixed README badges to reflect repository move from couchbase to blevesearch organization
Reviewed changes
Copilot reviewed 7 out of 427 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| go.mod | Updated Go version to 1.24.0 and upgraded all dependencies to latest versions |
| vellum_nommap.go | Added modern //go:build nommap directive for build constraints |
| vellum_mmap.go | Added modern //go:build !nommap directive for build constraints |
| vellum.go | Removed trailing empty line from package documentation |
| levenshtein/levenshtein_nfa.go | Converted triple-slash comments to standard Go double-slash format |
| builder.go | Converted ASCII art diagram from line comments to block comment format |
| README.md | Updated badge URLs to reference blevesearch organization instead of couchbase |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 428 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 428 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@CascadingRadium Can you confirm the |
|
Hi @abhinavdangeti, the Considering the fact that In short, yes—the vendor files are an artifact of the pre–Go modules era and can be safely removed. |
f347f67 to
7e3f074
Compare
- Replaces `crypto/md5` with `crypto/sha256` for internal hashing to allow compliance with FIPS-140 standard. - Fixes #23
crypto/sha256 for FIPS 140 compliance
|
This one comes with |
- Works with ..
- blevesearch/mmap-go#6
- blevesearch/vellum#25
- blevesearch/scorch_segment_api#70
- Enable windows testing workflow
- Fixes: #31
---------
Co-authored-by: Abhinav Dangeti <abhinav@couchbase.com>
bits-and-blooms/bitset,blevesearch/mmap-go,spf13/cobraedsrzf/mmap-go@v1.2.0intoblevesearch/mmap-go@mastermmap-go#6crypto/md5withcrypto/sha256for FIPS 140 compatibility (Replace MD5 with SHA-256 for FIPS 140 compatibility #26)