Skip to content

Upgrade dependencies, pivot to crypto/sha256 for FIPS 140 compliance#25

Merged
abhinavdangeti merged 11 commits intomasterfrom
deps
Jan 22, 2026
Merged

Upgrade dependencies, pivot to crypto/sha256 for FIPS 140 compliance#25
abhinavdangeti merged 11 commits intomasterfrom
deps

Conversation

@CascadingRadium
Copy link
Copy Markdown
Member

@CascadingRadium CascadingRadium commented Jan 17, 2026

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades project dependencies and performs maintenance tasks including removing legacy code, updating Go version, and fixing repository references.

Changes:

  • Updated Go version from 1.21 to 1.24.0 and upgraded all dependencies
  • Added modern //go:build directives alongside legacy +build tags
  • Fixed README badges to reflect repository move from couchbase to blevesearch organization

Reviewed changes

Copilot reviewed 7 out of 427 changed files in this pull request and generated no comments.

Show a summary per file
File Description
go.mod Updated Go version to 1.24.0 and upgraded all dependencies to latest versions
vellum_nommap.go Added modern //go:build nommap directive for build constraints
vellum_mmap.go Added modern //go:build !nommap directive for build constraints
vellum.go Removed trailing empty line from package documentation
levenshtein/levenshtein_nfa.go Converted triple-slash comments to standard Go double-slash format
builder.go Converted ASCII art diagram from line comments to block comment format
README.md Updated badge URLs to reference blevesearch organization instead of couchbase

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 428 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 428 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@abhinavdangeti
Copy link
Copy Markdown
Member

@CascadingRadium Can you confirm the vendor directory was basically unused since we introduced go.mod?

@CascadingRadium
Copy link
Copy Markdown
Member Author

Hi @abhinavdangeti, the vendor directory basically copies all the dependencies into the repo. Any dependency upgrade, followed by go mod tidy, would require running go mod vendor to keep the vendor files in sync.

Considering the fact that vellum is used as a dependency by zapx and others, the vendor files are basically unused, since zapx, bleve, and any upstream repo will look for vendor files in their own repositories.

In short, yes—the vendor files are an artifact of the pre–Go modules era and can be safely removed.

@abhinavdangeti abhinavdangeti changed the title Upgrade deps Upgrade dependencies: bitset, mmap-go, cobra; purge unused code Jan 22, 2026
@abhinavdangeti abhinavdangeti force-pushed the deps branch 2 times, most recently from f347f67 to 7e3f074 Compare January 22, 2026 18:13
abhinavdangeti and others added 2 commits January 22, 2026 11:23
- Replaces `crypto/md5` with `crypto/sha256` for internal hashing to
allow compliance with FIPS-140 standard.
- Fixes #23
@abhinavdangeti abhinavdangeti changed the title Upgrade dependencies: bitset, mmap-go, cobra; purge unused code Upgrade dependencies, pivot from crypto/md5 to crypto/sha256 for FIPS 140 compliance Jan 22, 2026
@abhinavdangeti abhinavdangeti changed the title Upgrade dependencies, pivot from crypto/md5 to crypto/sha256 for FIPS 140 compliance Upgrade dependencies, pivot to crypto/sha256 for FIPS 140 compliance Jan 22, 2026
@abhinavdangeti abhinavdangeti merged commit 686aa63 into master Jan 22, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in Geo-Spatial Search v2 Jan 22, 2026
@abhinavdangeti
Copy link
Copy Markdown
Member

This one comes with v1.2.0.

@CascadingRadium CascadingRadium deleted the deps branch January 22, 2026 18:36
abhinavdangeti added a commit to blevesearch/zapx that referenced this pull request Jan 26, 2026
- Works with ..
    - blevesearch/mmap-go#6
    - blevesearch/vellum#25
    - blevesearch/scorch_segment_api#70
- Enable windows testing workflow
- Fixes: #31

---------

Co-authored-by: Abhinav Dangeti <abhinav@couchbase.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

3 participants