fix(display-currency): correct HUF symbol placement in amount displays#3750
Open
peszpesz wants to merge 2 commits intoblinkbitcoin:mainfrom
Open
fix(display-currency): correct HUF symbol placement in amount displays#3750peszpesz wants to merge 2 commits intoblinkbitcoin:mainfrom
peszpesz wants to merge 2 commits intoblinkbitcoin:mainfrom
Conversation
Hungarian Forint conventionally places the symbol after the amount. formatCurrencyHelper always put the symbol before the number, causing the home screen balance to render "Ft0" instead of "0 Ft". Add a currencyId parameter and handle HUF as a special case to render amount-then-symbol with a separating space. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
HUF uses a suffix symbol ("Ft") which does not belong before the number
in an input field. The HUF currency pill already identifies the currency,
so the symbol is suppressed to avoid showing "Ft 0" in the input.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Hungarian Forint (HUF) amounts are displayed with the symbol as a prefix
throughout the app (e.g. "Ft276"), which is incorrect — HUF conventionally
places the symbol after the amount ("276 Ft").
Additionally, the amount input screen shows "Ft" before the number in the
input field, while the HUF currency pill already identifies the currency.
Changes
app/hooks/use-display-currency.tsAdded a
currencyIdparameter toformatCurrencyHelper. For HUF, thesymbol is placed after the amount with a separating space ("276 Ft").
This fixes all screens that use
formatMoneyAmountorformatCurrency:home screen balance, send screen, conversion screen, transaction list.
app/components/amount-input-screen/amount-input-screen-ui.tsxThe currency symbol is hidden for HUF in the amount input field.
The HUF currency pill already identifies the currency, so showing
"Ft" as a prefix in the input is redundant and incorrect.
Screens affected