Draft
Conversation
Update the root protobufjs resolution from 7.2.5 to 7.5.5 and refresh pnpm-lock.yaml so all workspace audit targets resolve to the patched version. This clears the critical pnpm audit advisory that caused the Buck audit targets to fail in CI. Also improve the shared pnpm audit wrapper to report failing advisories from the JSON audit result directly. The previous wrapper reran `pnpm audit` without JSON after detecting vulnerabilities, which could hang until Buck's 10 minute test timeout and leave CI with empty audit stdout/stderr. The wrapper now captures stderr for parse failures and prints concise advisory details for vulnerabilities at or above the configured audit level. Validation: - pnpm audit metadata reports critical: 0 - run_audit.py passes at --audit-level critical - all seven previously failing Buck audit targets pass
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the root protobufjs resolution from 7.2.5 to 7.5.5 and refresh pnpm-lock.yaml so all workspace audit targets resolve to the patched version. This clears the critical pnpm audit advisory that caused the Buck audit targets to fail in CI.
Also improve the shared pnpm audit wrapper to report failing advisories from the JSON audit result directly. The previous wrapper reran
pnpm auditwithout JSON after detecting vulnerabilities, which could hang until Buck's 10 minute test timeout and leave CI with empty audit stdout/stderr. The wrapper now captures stderr for parse failures and prints concise advisory details for vulnerabilities at or above the configured audit level.Validation: