Open
Conversation
Member
Member
|
i personally would prefer to keep the library small (in size and in memory usage) and the map looks fairly big for functionality that could be moved to where it's being called. |
Member
|
How about extending Yano just enough so that the colors can be defined
locally within the project where this functionality is being used? Then, if
it needs to be used in more than N projects (let's use 2 for N?) we can
move the functionality into the core library.
@ALL, how does that sound as a method of governing what makes it into the
core library? Are folks happy with "2"?
…On Sun, Nov 29, 2020, 9:45 PM Steven Le ***@***.***> wrote:
i personally would prefer to keep the library small (in size and in memory
usage) and the map looks fairly big for functionality that could be moved
to where it's being called.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#48 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAE527LROZ2RTZD6CSSXFADSSMWPTANCNFSM4UGWHTIA>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This might be a call on weight, whether we want to have this functionality for users or insist on HEX/RGB values instead.