feat: Support pseudo-versions in Go module proxy#187
Merged
alecthomas merged 3 commits intoblock:mainfrom Mar 17, 2026
Merged
Conversation
Go allows module versions to be specified as a pesudo-version string, like "v0.0.0-20191109021931-daa7c04131f5". This commit adds support to the Go private module fetcher to extract and use the git object name when handling a pseudo-version provided by a client.
worstell
approved these changes
Mar 16, 2026
| return nil, errors.Wrapf(err, "git clone: %s", string(output)) | ||
| } | ||
| // #nosec G204 - cloneDir and gitRef are controlled by us | ||
| cmd = exec.CommandContext(ctx, "git", "-C", cloneDir, "checkout", gitRef) |
Contributor
There was a problem hiding this comment.
Suggested change
| cmd = exec.CommandContext(ctx, "git", "-C", cloneDir, "checkout", gitRef) | |
| cmd = exec.CommandContext(ctx, "git", "-C", cloneDir, "checkout", "--", gitRef) |
Contributor
Author
There was a problem hiding this comment.
If I add --, git will attempt restore the file named by gitRef with its version from the index. I instead want it to checkout files name by an object reference. The command is correct as-is.
Contributor
Author
|
@worstell, can you merge this PR? I do not have access to do that myself even with an approval. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go allows module versions to be specified as a pesudo-version string,
like "v0.0.0-20191109021931-daa7c04131f5". This commit adds support to
the Go private module fetcher to extract and use the git object name
when handling a pseudo-version provided by a client.