Skip to content

fix: add app.kubernetes.io/name label to playpen pods#201

Merged
alecthomas merged 1 commit intomainfrom
jrobotham/playpen-sidecar-label
Mar 19, 2026
Merged

fix: add app.kubernetes.io/name label to playpen pods#201
alecthomas merged 1 commit intomainfrom
jrobotham/playpen-sidecar-label

Conversation

@jrobotham-square
Copy link
Copy Markdown
Contributor

@jrobotham-square jrobotham-square commented Mar 19, 2026

Copy the app.kubernetes.io/name label from the deployment to playpen pods so Istio's Sidecar ingress rules apply correctly.

The Istio Sidecar resource that maps inbound mesh traffic (port 8088)
to the app (port 8080) selects pods by app.kubernetes.io/name. Without
this label, playpen pods are not matched and mesh routing fails with
a TLS error (mTLS traffic bypasses envoy and hits the app directly).

Amp-Thread-ID: https://ampcode.com/threads/T-019d0486-63e6-754c-88dc-2af0542ee0c9
Co-authored-by: Amp <amp@ampcode.com>
@jrobotham-square jrobotham-square requested a review from a team as a code owner March 19, 2026 07:46
@jrobotham-square jrobotham-square requested review from stuartwdouglas and removed request for a team March 19, 2026 07:46
@alecthomas alecthomas merged commit 67f6395 into main Mar 19, 2026
8 checks passed
@alecthomas alecthomas deleted the jrobotham/playpen-sidecar-label branch March 19, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants