feat: make HTTP header to log attribute mapping configurable#257
Closed
stuartwdouglas wants to merge 1 commit intomainfrom
Closed
feat: make HTTP header to log attribute mapping configurable#257stuartwdouglas wants to merge 1 commit intomainfrom
stuartwdouglas wants to merge 1 commit intomainfrom
Conversation
Replace the hard-coded X-Blox-Workstation-Id header extraction in
LoggingMiddleware with a general-purpose header-attrs config map in the
log block. Any header can now be mapped to a log attribute via config:
log {
header-attrs = {
"X-Blox-Workstation-Id" = "blox.workstation_id"
}
}
Amp-Thread-ID: https://ampcode.com/threads/T-019d8a28-e244-724f-834e-79e196aab7c2
Co-authored-by: Amp <amp@ampcode.com>
Collaborator
|
#256 won the race! But also consolidates the middleware into the logging package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the hard-coded
X-Blox-Workstation-Idheader extraction inLoggingMiddlewarewith a general-purposeheader-attrsconfig map in thelogblock.Any header can now be mapped to a log attribute via config:
Changes
HeaderAttrs map[string]stringtologging.ConfigLoggingMiddlewareto accept the map and iterate over itnewServer