fix: recover panics in worker goroutines#258
Merged
stuartwdouglas merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
stuartwdouglas
requested review from
jrobotham-square
and removed request for
a team
Panics in scheduled jobs (e.g. from metadatadb, logging, or feature flags) would crash the entire process with exit code 2. Wrap job execution in a deferred recover so panics are captured as errors with a stack trace, logged, and the worker stays alive. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d8a56-4eee-7490-8132-1d5bbea7d251
stuartwdouglas
force-pushed
the
sdouglas/recover-scheduler-panics
branch
from
5bd1962 to
3ef9845
Compare
alecthomas
approved these changes
Apr 14, 2026
stuartwdouglas
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Panics in scheduled jobs (e.g. from metadatadb, logging, or feature flags) would crash the entire process with exit code 2. This wraps job execution in a deferred recover so panics are captured as errors with a stack trace, logged, and the worker stays alive.