Conversation
nssherpa
approved these changes
Feb 3, 2026
Contributor
nssherpa
left a comment
nssherpa
left a comment
There was a problem hiding this comment.
Didn't look deeply as I'm assuming this was just a git revert..
alecthomas
approved these changes
Feb 3, 2026
js-murph
added a commit
that referenced
this pull request
Feb 5, 2026
# What? Re-implements #77, which adds support for private gomod repositories. # Why? So that we are able to cache private go modules. # Tests? Includes new unit tests. Additionally some manual testing has been performed... ```bash time curl http://localhost:8080/gomod/github.com/<org>/<repo>/@latest {"Version":"v0.0.6","Time":"2021-08-12T18:29:12Z"} real 1m43.818s user 0m0.009s sys 0m0.017s time curl http://localhost:8080/gomod/github.com/<org>/<repo>/@latest {"Version":"v0.0.6","Time":"2021-08-12T18:29:12Z"} real 0m0.070s user 0m0.006s sys 0m0.011s ``` --------- Co-authored-by: Alec Thomas <aat@block.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the gomod private implementation
Why?
It was deeply flawed and we need to modify our github caching for this to work