Skip to content

Remove cachew.hcl from Docker image#88

Closed
nssherpa wants to merge 1 commit intomainfrom
remove-config-from-image
Closed

Remove cachew.hcl from Docker image#88
nssherpa wants to merge 1 commit intomainfrom
remove-config-from-image

Conversation

@nssherpa
Copy link
Copy Markdown
Contributor

@nssherpa nssherpa commented Feb 5, 2026

No description provided.

@nssherpa nssherpa force-pushed the remove-config-from-image branch 5 times, most recently from 627fd2e to 1574e1f Compare February 5, 2026 21:00
@nssherpa nssherpa force-pushed the remove-config-from-image branch from 1574e1f to 2b5aac0 Compare February 5, 2026 22:32
@nssherpa nssherpa marked this pull request as ready for review February 5, 2026 22:41
@nssherpa nssherpa requested a review from a team as a code owner February 5, 2026 22:41
@nssherpa nssherpa requested review from alecthomas and removed request for a team February 5, 2026 22:41
Comment thread docker/Dockerfile

# Bind to all interfaces in Docker (can be overridden with CACHEW_BIND env var)
ENV CACHEW_BIND=0.0.0.0:8080
ENV CACHEW_CONFIG=/app/config/cachew.hcl
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noticed that ---config via the CMD doesn't work and needs to be passed this way.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should fix that...

Comment thread docker/Dockerfile

# Copy default configuration file
COPY cachew.hcl /app/cachew.hcl

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can leave this, and still vol mount over it to override no? Leaving it in gives random people a decent base starting point that Just Works

@nssherpa nssherpa marked this pull request as draft February 5, 2026 23:33
@nssherpa
Copy link
Copy Markdown
Contributor Author

nssherpa commented Feb 6, 2026

Fix for --config not being respected https://github.com/alecthomas/kong/pull/580/changes

@nssherpa nssherpa closed this Feb 6, 2026
@nssherpa nssherpa deleted the remove-config-from-image branch February 9, 2026 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants