Skip to content

fix: Remove clone-depth from clonemanager #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
js-murph merged 1 commit into from
Feb 6, 2026
Merged

fix: Remove clone-depth from clonemanager #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion cachew.hcl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@

git {
mirror-root = "./state/git-mirrors"
clone-depth = 1000
bundle-interval = "24h"
}

Expand Down
15 changes: 6 additions & 9 deletions internal/gitclone/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ type Config struct {
RootDir string
FetchInterval time.Duration
RefCheckInterval time.Duration
CloneDepth int
GitConfig GitTuningConfig
}

Expand Down Expand Up @@ -286,15 +285,13 @@ func (r *Repository) executeClone(ctx context.Context, config Config) error {
}

// #nosec G204 - r.upstreamURL and r.path are controlled by us
args := []string{"clone"}
if config.CloneDepth > 0 {
args = append(args, "--depth", strconv.Itoa(config.CloneDepth))
args := []string{
"clone",
"-c", "http.postBuffer=" + strconv.Itoa(config.GitConfig.PostBuffer),
"-c", "http.lowSpeedLimit=" + strconv.Itoa(config.GitConfig.LowSpeedLimit),
"-c", "http.lowSpeedTime=" + strconv.Itoa(int(config.GitConfig.LowSpeedTime.Seconds())),
r.upstreamURL, r.path,
}
args = append(args,
"-c", "http.postBuffer="+strconv.Itoa(config.GitConfig.PostBuffer),
"-c", "http.lowSpeedLimit="+strconv.Itoa(config.GitConfig.LowSpeedLimit),
"-c", "http.lowSpeedTime="+strconv.Itoa(int(config.GitConfig.LowSpeedTime.Seconds())),
r.upstreamURL, r.path)

cmd, err := gitCommand(ctx, r.upstreamURL, args...)
if err != nil {
Expand Down
1 change: 0 additions & 1 deletion internal/gitclone/manager_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ func TestNewManager(t *testing.T) {
RootDir: tmpDir,
FetchInterval: 15 * time.Minute,
RefCheckInterval: 10 * time.Second,
CloneDepth: 0,
GitConfig: DefaultGitTuningConfig(),
}

Expand Down
1 change: 0 additions & 1 deletion internal/strategy/git/backend.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ func (s *Strategy) ensureRefsUpToDate(ctx context.Context, repo *gitclone.Reposi
RootDir: s.config.MirrorRoot,
FetchInterval: s.config.FetchInterval,
RefCheckInterval: s.config.RefCheckInterval,
CloneDepth: s.config.CloneDepth,
GitConfig: gitclone.DefaultGitTuningConfig(),
}
if err := repo.EnsureRefsUpToDate(ctx, gitcloneConfig); err != nil {
Expand Down
4 changes: 0 additions & 4 deletions internal/strategy/git/git.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ type Config struct {
FetchInterval time.Duration `hcl:"fetch-interval,optional" help:"How often to fetch from upstream in minutes." default:"15m"`
RefCheckInterval time.Duration `hcl:"ref-check-interval,optional" help:"How long to cache ref checks." default:"10s"`
BundleInterval time.Duration `hcl:"bundle-interval,optional" help:"How often to generate bundles. 0 disables bundling." default:"0"`
CloneDepth int `hcl:"clone-depth,optional" help:"Depth for shallow clones. 0 means full clone." default:"0"`
}

type Strategy struct {
Expand Down Expand Up @@ -63,7 +62,6 @@ func New(ctx context.Context, config Config, scheduler jobscheduler.Scheduler, c
RootDir: config.MirrorRoot,
FetchInterval: config.FetchInterval,
RefCheckInterval: config.RefCheckInterval,
CloneDepth: config.CloneDepth,
GitConfig: gitclone.DefaultGitTuningConfig(),
})
if err != nil {
Expand Down Expand Up @@ -244,7 +242,6 @@ func (s *Strategy) startClone(ctx context.Context, repo *gitclone.Repository) {
RootDir: s.config.MirrorRoot,
FetchInterval: s.config.FetchInterval,
RefCheckInterval: s.config.RefCheckInterval,
CloneDepth: s.config.CloneDepth,
GitConfig: gitclone.DefaultGitTuningConfig(),
}

Expand Down Expand Up @@ -292,7 +289,6 @@ func (s *Strategy) backgroundFetch(ctx context.Context, repo *gitclone.Repositor
RootDir: s.config.MirrorRoot,
FetchInterval: s.config.FetchInterval,
RefCheckInterval: s.config.RefCheckInterval,
CloneDepth: s.config.CloneDepth,
GitConfig: gitclone.DefaultGitTuningConfig(),
}

Expand Down