refAllDeclsRecursive-fix #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gballet
reviewed
Nov 16, 2025
src/utils.zig
Outdated
|
|
||
| pub fn eql(self: *const Self, other: *Self) bool { | ||
| pub fn eql(self: *const Self, other: *const Self) bool { | ||
| // Compare lengths first, then use std.mem.eql for slice contents |
Collaborator
There was a problem hiding this comment.
let's make sure comments bring some value, which is not the case with this (I presume ai-generated) one.
Suggested change
| // Compare lengths first, then use std.mem.eql for slice contents |
src/utils.zig
Outdated
| } | ||
| return true; | ||
| } else { | ||
| // For primitive types, use std.mem.eql |
Collaborator
There was a problem hiding this comment.
Suggested change
| // For primitive types, use std.mem.eql |
- use std.meta.eql for deep comparison for non primitive types
gballet
force-pushed
the
refAllDeclsRecursive-fix
branch
from
78f9333 to
48f7c46
Compare
Collaborator
|
|
gballet
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses blockblaz/zeam#331 (comment) and fixes blockblaz/zeam#336