update to use SSZ hasher agnostic hashTreeRoot API #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chetanyb
requested review from
anshalshukla and
g11tech
and removed request for
anshalshukla
Comment on lines
+7
to
+14
| pub fn hashTreeRoot( | ||
| comptime T: type, | ||
| value: T, | ||
| out: *[Sha256.digest_length]u8, | ||
| allocator: Allocator, | ||
| ) !void { | ||
| try ssz.hashTreeRoot(Sha256, T, value, out, allocator); | ||
| } |
Collaborator
There was a problem hiding this comment.
I think we can add a build flag and make it something like
pub const Hasher = if (build_options.use_poseidon) Poseidon else Sha256;
pub fn hashTreeRoot(
comptime T: type,
value: T,
out: *[Hasher.digest_length]u8,
allocator: std.mem.Allocator,
) !void {
try ssz.hashTreeRoot(Hasher, T, value, out, allocator);
}
g11tech
reviewed
Jan 25, 2026
| .url = "git+https://github.com/blockblaz/ssz.zig#5ce7322fc45cab4f215021cae2579d1343e05d55", | ||
| .hash = "ssz-0.0.9-Lfwd61PEAgAUPJfUQiK4R5gRX_lTWOd_qYwNT-KAhRLA", | ||
| .url = "https://github.com/blockblaz/ssz.zig/archive/0ce92a8f093a321b0d0815eec6c90bd4e745d8e1.tar.gz", | ||
| .hash = "ssz-0.0.9-Lfwd6wvKAgA3JZjtfbeXeQG6zle1K_K2j6HPmQJJF4an", |
Member
There was a problem hiding this comment.
can we get a new release for ssz?
Member
There was a problem hiding this comment.
merging this PR for now, lets do it in followup
g11tech
changed the title
GrapeBaBa
pushed a commit
that referenced
this pull request
Jan 25, 2026
* chore: point to latest ssz commit * feat: add Sha256 ssz hashTreeRoot wrapper * refactor: use the updated hashTreeRoot wrapper --------- Co-authored-by: g11tech <gajinder@zeam.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: