add aggregated attestation signature metrics #535
+68
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
g11tech
reviewed
Jan 29, 2026
| const num_agg_sigs = aggregation.attestation_signatures.len(); | ||
| zeam_metrics.metrics.lean_pq_sig_aggregated_signatures_total.incrBy(num_agg_sigs); | ||
|
|
||
| var total_attestations_in_agg: u64 = 0; |
Member
There was a problem hiding this comment.
why is this just not attestations.len
Member
Author
There was a problem hiding this comment.
Attestations with the same data_root are grouped into a single aggregated signature, so aggregation.attestation_signatures.len() counts the actual aggregated signatures produced while attestations.len() would count the raw input attestations before grouping.
Member
Author
There was a problem hiding this comment.
For example 10 input attestations might produce only 2 aggregated signatures if they group by data_root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#492