Skip to content

add aggregated attestation signature metrics #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bomanaps wants to merge 4 commits into
base: main
Choose a base branch
from
+68 −3
Open

add aggregated attestation signature metrics #535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be25f47
add aggregated attestation signature metrics
bomanaps Jan 28, 2026
136c988
Merge branch 'blockblaz:main' into attestations/metrics
bomanaps Jan 28, 2026
c364493
Merge branch 'blockblaz:main' into attestations/metrics
bomanaps Jan 29, 2026
529a0e6
Merge branch 'blockblaz:main' into attestations/metrics
bomanaps Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions pkgs/metrics/src/lib.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,13 @@ const Metrics = struct {
lean_attestation_validation_time_seconds: ForkChoiceAttestationValidationTimeHistogram,
lean_pq_signature_attestation_signing_time_seconds: PQSignatureSigningHistogram,
lean_pq_signature_attestation_verification_time_seconds: PQSignatureVerificationHistogram,
// Aggregated attestation signature metrics
lean_pq_sig_aggregated_signatures_total: PQSigAggregatedSignaturesTotalCounter,
lean_pq_sig_attestations_in_aggregated_signatures_total: PQSigAttestationsInAggregatedTotalCounter,
lean_pq_sig_attestation_signatures_building_time_seconds: PQSigBuildingTimeHistogram,
lean_pq_sig_aggregated_signatures_verification_time_seconds: PQSigAggregatedVerificationHistogram,
lean_pq_sig_aggregated_signatures_valid_total: PQSigAggregatedValidCounter,
lean_pq_sig_aggregated_signatures_invalid_total: PQSigAggregatedInvalidCounter,
// Network peer metrics
lean_connected_peers: LeanConnectedPeersGauge,
lean_peer_connection_events_total: PeerConnectionEventsCounter,
Expand Down Expand Up @@ -79,6 +86,13 @@ const Metrics = struct {
const ForkChoiceAttestationsValidLabeledCounter = metrics_lib.CounterVec(u64, struct { source: []const u8 });
const ForkChoiceAttestationsInvalidLabeledCounter = metrics_lib.CounterVec(u64, struct { source: []const u8 });
const ForkChoiceAttestationValidationTimeHistogram = metrics_lib.Histogram(f32, &[_]f32{ 0.005, 0.01, 0.025, 0.05, 0.1, 1 });
// Aggregated attestation signature metric types
const PQSigAggregatedSignaturesTotalCounter = metrics_lib.Counter(u64);
const PQSigAttestationsInAggregatedTotalCounter = metrics_lib.Counter(u64);
const PQSigBuildingTimeHistogram = metrics_lib.Histogram(f32, &[_]f32{ 0.005, 0.01, 0.025, 0.05, 0.1, 1 });
const PQSigAggregatedVerificationHistogram = metrics_lib.Histogram(f32, &[_]f32{ 0.005, 0.01, 0.025, 0.05, 0.1, 1 });
const PQSigAggregatedValidCounter = metrics_lib.Counter(u64);
const PQSigAggregatedInvalidCounter = metrics_lib.Counter(u64);
// Network peer metric types
const LeanConnectedPeersGauge = metrics_lib.Gauge(u64);
const PeerConnectionEventsCounter = metrics_lib.CounterVec(u64, struct { direction: []const u8, result: []const u8 });
Expand Down Expand Up @@ -189,6 +203,18 @@ fn observePQSignatureAttestationVerification(ctx: ?*anyopaque, value: f32) void
histogram.observe(value);
}

fn observePQSigBuildingTime(ctx: ?*anyopaque, value: f32) void {
const histogram_ptr = ctx orelse return; // No-op if not initialized
const histogram: *Metrics.PQSigBuildingTimeHistogram = @ptrCast(@alignCast(histogram_ptr));
histogram.observe(value);
}

fn observePQSigAggregatedVerification(ctx: ?*anyopaque, value: f32) void {
const histogram_ptr = ctx orelse return; // No-op if not initialized
const histogram: *Metrics.PQSigAggregatedVerificationHistogram = @ptrCast(@alignCast(histogram_ptr));
histogram.observe(value);
}

/// The public variables the application interacts with.
/// Calling `.start()` on these will start a new timer.
pub var chain_onblock_duration_seconds: Histogram = .{
Expand Down Expand Up @@ -232,6 +258,14 @@ pub var lean_pq_signature_attestation_verification_time_seconds: Histogram = .{
.context = null,
.observe = &observePQSignatureAttestationVerification,
};
pub var lean_pq_sig_attestation_signatures_building_time_seconds: Histogram = .{
.context = null,
.observe = &observePQSigBuildingTime,
};
pub var lean_pq_sig_aggregated_signatures_verification_time_seconds: Histogram = .{
.context = null,
.observe = &observePQSigAggregatedVerification,
};

/// Initializes the metrics system. Must be called once at startup.
pub fn init(allocator: std.mem.Allocator) !void {
Expand Down Expand Up @@ -263,6 +297,13 @@ pub fn init(allocator: std.mem.Allocator) !void {
.lean_attestation_validation_time_seconds = Metrics.ForkChoiceAttestationValidationTimeHistogram.init("lean_attestation_validation_time_seconds", .{ .help = "Time taken to validate attestation." }, .{}),
.lean_pq_signature_attestation_signing_time_seconds = Metrics.PQSignatureSigningHistogram.init("lean_pq_signature_attestation_signing_time_seconds", .{ .help = "Time taken to sign an attestation." }, .{}),
.lean_pq_signature_attestation_verification_time_seconds = Metrics.PQSignatureVerificationHistogram.init("lean_pq_signature_attestation_verification_time_seconds", .{ .help = "Time taken to verify an attestation signature." }, .{}),
// Aggregated attestation signature metrics
.lean_pq_sig_aggregated_signatures_total = Metrics.PQSigAggregatedSignaturesTotalCounter.init("lean_pq_sig_aggregated_signatures_total", .{ .help = "Total number of aggregated signatures." }, .{}),
.lean_pq_sig_attestations_in_aggregated_signatures_total = Metrics.PQSigAttestationsInAggregatedTotalCounter.init("lean_pq_sig_attestations_in_aggregated_signatures_total", .{ .help = "Total number of attestations included into aggregated signatures." }, .{}),
.lean_pq_sig_attestation_signatures_building_time_seconds = Metrics.PQSigBuildingTimeHistogram.init("lean_pq_sig_attestation_signatures_building_time_seconds", .{ .help = "Time taken to build aggregated attestation signatures." }, .{}),
.lean_pq_sig_aggregated_signatures_verification_time_seconds = Metrics.PQSigAggregatedVerificationHistogram.init("lean_pq_sig_aggregated_signatures_verification_time_seconds", .{ .help = "Time taken to verify an aggregated attestation signature." }, .{}),
.lean_pq_sig_aggregated_signatures_valid_total = Metrics.PQSigAggregatedValidCounter.init("lean_pq_sig_aggregated_signatures_valid_total", .{ .help = "Total number of valid aggregated signatures." }, .{}),
.lean_pq_sig_aggregated_signatures_invalid_total = Metrics.PQSigAggregatedInvalidCounter.init("lean_pq_sig_aggregated_signatures_invalid_total", .{ .help = "Total number of invalid aggregated signatures." }, .{}),
// Network peer metrics
.lean_connected_peers = Metrics.LeanConnectedPeersGauge.init("lean_connected_peers", .{ .help = "Number of currently connected peers." }, .{}),
.lean_peer_connection_events_total = try Metrics.PeerConnectionEventsCounter.init(allocator, "lean_peer_connection_events_total", .{ .help = "Total peer connection events by direction and result." }, .{}),
Expand Down Expand Up @@ -293,6 +334,8 @@ pub fn init(allocator: std.mem.Allocator) !void {
lean_attestation_validation_time_seconds.context = @ptrCast(&metrics.lean_attestation_validation_time_seconds);
lean_pq_signature_attestation_signing_time_seconds.context = @ptrCast(&metrics.lean_pq_signature_attestation_signing_time_seconds);
lean_pq_signature_attestation_verification_time_seconds.context = @ptrCast(&metrics.lean_pq_signature_attestation_verification_time_seconds);
lean_pq_sig_attestation_signatures_building_time_seconds.context = @ptrCast(&metrics.lean_pq_sig_attestation_signatures_building_time_seconds);
lean_pq_sig_aggregated_signatures_verification_time_seconds.context = @ptrCast(&metrics.lean_pq_sig_aggregated_signatures_verification_time_seconds);

g_initialized = true;
}
Expand Down
17 changes: 17 additions & 0 deletions pkgs/node/src/chain.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,12 +323,29 @@ pub const BeamChain = struct {
// Lock mutex to protect concurrent access to gossip_signatures and aggregated_payloads
self.forkChoice.signatures_mutex.lock();
defer self.forkChoice.signatures_mutex.unlock();
const building_timer = zeam_metrics.lean_pq_sig_attestation_signatures_building_time_seconds.start();
try aggregation.computeAggregatedSignatures(
attestations,
&pre_state.validators,
&self.forkChoice.gossip_signatures,
&self.forkChoice.aggregated_payloads,
);
_ = building_timer.observe();

// Record aggregated signature metrics
const num_agg_sigs = aggregation.attestation_signatures.len();
zeam_metrics.metrics.lean_pq_sig_aggregated_signatures_total.incrBy(num_agg_sigs);

var total_attestations_in_agg: u64 = 0;
Copy link
Member

@g11tech g11tech Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this just not attestations.len

Copy link
Member Author

@bomanaps bomanaps Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Attestations with the same data_root are grouped into a single aggregated signature, so aggregation.attestation_signatures.len() counts the actual aggregated signatures produced while attestations.len() would count the raw input attestations before grouping.

Copy link
Member Author

@bomanaps bomanaps Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For example 10 input attestations might produce only 2 aggregated signatures if they group by data_root.

for (aggregation.attestations.constSlice()) |agg_att| {
const bits_len = agg_att.aggregation_bits.len();
for (0..bits_len) |i| {
if (agg_att.aggregation_bits.get(i) catch false) {
total_attestations_in_agg += 1;
}
}
}
zeam_metrics.metrics.lean_pq_sig_attestations_in_aggregated_signatures_total.incrBy(total_attestations_in_agg);

// keeping for later when execution will be integrated into lean
// const timestamp = self.config.genesis.genesis_time + opts.slot * params.SECONDS_PER_SLOT;
Expand Down
11 changes: 8 additions & 3 deletions pkgs/state-transition/src/transition.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,14 @@ pub fn verifySignatures(
const epoch: u64 = aggregated_attestation.data.slot;

// Verify the aggregated signature proof
const verification_timer = zeam_metrics.lean_pq_signature_attestation_verification_time_seconds.start();
try signature_proof.verify(public_keys.items, &message_hash, epoch);
_ = verification_timer.observe();
const agg_verification_timer = zeam_metrics.lean_pq_sig_aggregated_signatures_verification_time_seconds.start();
signature_proof.verify(public_keys.items, &message_hash, epoch) catch |err| {
_ = agg_verification_timer.observe();
zeam_metrics.metrics.lean_pq_sig_aggregated_signatures_invalid_total.incr();
return err;
};
_ = agg_verification_timer.observe();
zeam_metrics.metrics.lean_pq_sig_aggregated_signatures_valid_total.incr();
}

// Verify proposer signature (still individual)
Expand Down