Skip to content

Encoding fix #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chetanyb merged 2 commits into from
Jan 4, 2026
Merged

Encoding fix #6

chetanyb merged 2 commits into from
Jan 4, 2026

Conversation

@chetanyb
Copy link

@chetanyb chetanyb commented Jan 2, 2026 •
edited
Loading

Summary

  • Add literal-length tests for >255 and >65535
  • Replace truncating length writes with spec‑correct 1–4 byte encoding
  • Align emitLiteral with the Snappy format description
  • Fix literal length encoding for sizes > 65535 (previously only 2 bytes were emitted, truncating higher bits)

related blockblaz/zeam#465

@chetanyb chetanyb requested review from GrapeBaBa and g11tech January 2, 2026 15:50
GrapeBaBa
GrapeBaBa reviewed Jan 4, 2026
View reviewed changes
@chetanyb chetanyb merged commit 77cb4c2 into blockblaz:master Jan 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GrapeBaBa GrapeBaBa GrapeBaBa approved these changes

@g11tech g11tech Awaiting requested review from g11tech

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chetanyb @GrapeBaBa