Fix/ens name by heronlancellot · Pull Request #422 · blockful/swaplace-dapp

heronlancellot · 2024-09-19T18:54:25Z

Closes #320

vercel · 2024-09-19T18:54:28Z

@heronlancellot is attempting to deploy a commit to the Blockful Team on Vercel.

A member of the Team first needs to authorize it.

FrancoAguzzi · 2024-09-19T19:34:54Z

components/01-atoms/ENSAvatar.tsx

-import { EthereumAddress } from "@/lib/shared/types";
-import cc from "classcat";
-import { useEffect, useState } from "react";
+// /* eslint-disable react-hooks/exhaustive-deps */


Hi @heronlancellot

Whenever commenting out features from the project, can you please add a documentation at the top of the comments explaining this feature is out for a while?

I'd rather using this comment methodology /** */

FrancoAguzzi · 2024-09-19T19:36:25Z

components/01-atoms/SearchBar.tsx

 import { useContext, useEffect } from "react";
-import { ENS } from "web3-eth-ens";
-import Web3 from "web3";
+// import { ENS } from "web3-eth-ens";


Same thing around comment methodology in here

FrancoAguzzi · 2024-09-19T19:36:41Z

components/02-molecules/EnsNameAndAddressWallet.tsx

-  const { primaryName } = useEnsData({
-    ensAddress: authenticatedUserAddress,
-  });
+  // const { primaryName } = useEnsData({


FrancoAguzzi · 2024-09-19T19:37:04Z

components/02-molecules/EnsNameAndAddressWallet.tsx

-  });
+  // const { primaryName } = useEnsData({
+  //   ensAddress: authenticatedUserAddress,
+  // });


Please also add docs above the comments (one per file is enough) saying why this feature is out for now

For each file, please

FrancoAguzzi · 2024-09-19T19:37:36Z

components/02-molecules/OfferSummary.tsx

-                      searchedENSName
-                        ? `${searchedENSName} offers`
-                        : validatedAddressToSwap
+                      // searchedENSName


Please use the other comment syntax

@heronlancellot

FrancoAguzzi · 2024-09-19T19:37:50Z

components/02-molecules/TheHeader.tsx

+                    className="rounded-[10px] flex items-center justify-center w-full h-full"
                  >
-                    <ENSAvatar avatarENSAddress={authenticatedUserAddress} />
+                    {/* <ENSAvatar avatarENSAddress={authenticatedUserAddress} /> */}


Here as well, adding a comment on why this is out

FrancoAguzzi · 2024-09-19T19:37:58Z

components/02-molecules/UserOfferInfo.tsx

        <div className="flex gap-2">
          <div>
-            {address && (
+            {/* {address && (


FrancoAguzzi · 2024-09-19T19:38:13Z

components/04-templates/SwapSection.tsx

 export const SwapSection = () => {
  return (
-    <div className="max-w-[1280px] xl:max-h-[720px] w-full flex xl:flex-row flex-col lg:justify-center">
+    <div className="max-w-[1280px] xl:max-h-[720px] w-full flex xl:flex-row flex-col lg:justify-center xl:h-full">


This is already in another PR, shall update with merge

FrancoAguzzi · 2024-09-19T19:38:32Z

lib/client/hooks/useENSData.tsx

-  SUCCESS,
-  ERROR,
-}
+// export enum ENSAvatarQueryStatus {


Please refer to the above comments and apply the mentioned rules here!

components/01-atoms/ENSAvatar.tsx

components/01-atoms/SearchBar.tsx

FrancoAguzzi · 2024-09-19T22:11:11Z

components/01-atoms/index.ts

 export * from "./ConnectWallet";
 export * from "./DisconnectWallet";
-export * from "./ENSAvatar";
+// export * from "./ENSAvatar";


Please add a comment in here as well

components/02-molecules/UserOfferInfo.tsx

FrancoAguzzi · 2024-09-19T22:30:56Z

lib/client/hooks/useENSData.tsx

@@ -1,3 +1,23 @@
+/**
+ * @deprecated This hook is deprecated because the searched ENS address
+ * sometimes returns incorrect results, which negatively impacts the user flow


Please replicate my suggestions above to the exact same text

FrancoAguzzi · 2024-09-19T22:31:27Z

lib/client/hooks/useENSData.tsx

+ * `ensAddress` changes. It updates the state variables `primaryName` and `avatarQueryStatus`
+ * based on the fetched data or any errors encountered during the fetch process.
+ *
+ * @param {Props} props - The properties object.


Please do not type the whole props object but each single prop

FrancoAguzzi · 2024-09-19T22:31:39Z

lib/client/hooks/useENSData.tsx

+ * based on the fetched data or any errors encountered during the fetch process.
+ *
+ * @param {Props} props - The properties object.
+ * @param {EthereumAddress | null} props.ensAddress - The ENS address to fetch the data for.


Please do not mention props.

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

components/01-atoms/ENSAvatar.tsx

components/01-atoms/SearchBar.tsx

components/01-atoms/index.ts

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

components/01-atoms/SearchBar.tsx

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

components/01-atoms/ENSAvatar.tsx

components/01-atoms/SearchBar.tsx

components/02-molecules/EnsNameAndAddressWallet.tsx

FrancoAguzzi · 2024-09-23T20:25:18Z

components/02-molecules/EnsNameAndAddressWallet.tsx

          <div className="flex flex-col">
            <div className="flex items-center justify-start gap-2">
-              {primaryName && (
+              {/* {primaryName && (


This comment section can reproduce the method of commenting deprecated feature that the other sections received! Please go ahead and do so 🧑🏼‍💻👊🏼🧑🏼‍💻

components/02-molecules/OfferSummary.tsx

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

components/01-atoms/SearchBar.tsx

components/02-molecules/EnsNameAndAddressWallet.tsx

components/01-atoms/SearchBar.tsx

components/02-molecules/EnsNameAndAddressWallet.tsx

FrancoAguzzi · 2024-09-24T18:34:59Z

components/02-molecules/EnsNameAndAddressWallet.tsx

  const { primaryName } = useEnsData({
    ensAddress: authenticatedUserAddress,
  });


This comment is missing documentation on why it is commented out

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

heronlancellot added 2 commits September 19, 2024 14:46

feat: add h-full into swap-section

406f34b

fix: remove ens searched address

ebc5733

heronlancellot requested a review from FrancoAguzzi September 19, 2024 18:54

FrancoAguzzi suggested changes Sep 19, 2024

View reviewed changes

fix: commented sections and add documentation about ens-name-address

73162ca

FrancoAguzzi suggested changes Sep 19, 2024

View reviewed changes

heronlancellot and others added 8 commits September 20, 2024 09:11

Update components/01-atoms/ENSAvatar.tsx

7ba9d5a

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/ENSAvatar.tsx

280c696

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/02-molecules/UserOfferInfo.tsx

f64f7c3

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/ENSAvatar.tsx

8e8bdbe

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/SearchBar.tsx

a70daeb

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/02-molecules/UserOfferInfo.tsx

be10d92

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

fix: comment text

ff85adc

fix: comment text

88078a7

FrancoAguzzi reviewed Sep 20, 2024

View reviewed changes

components/01-atoms/ENSAvatar.tsx Outdated Show resolved Hide resolved

components/01-atoms/SearchBar.tsx Show resolved Hide resolved

components/01-atoms/SearchBar.tsx Outdated Show resolved Hide resolved

components/01-atoms/index.ts Outdated Show resolved Hide resolved

heronlancellot and others added 4 commits September 20, 2024 10:58

Update components/01-atoms/ENSAvatar.tsx

995f856

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/SearchBar.tsx

8805899

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/SearchBar.tsx

c3a6bc1

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/index.ts

dc4300f

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

FrancoAguzzi reviewed Sep 20, 2024

View reviewed changes

components/01-atoms/SearchBar.tsx Show resolved Hide resolved

components/01-atoms/SearchBar.tsx Show resolved Hide resolved

components/01-atoms/SearchBar.tsx Outdated Show resolved Hide resolved

heronlancellot and others added 3 commits September 20, 2024 11:03

Update components/01-atoms/SearchBar.tsx

a4d04b2

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/SearchBar.tsx

5410490

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/SearchBar.tsx

1c87f74

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

RafaDSan assigned RafaDSan and heronlancellot and unassigned RafaDSan Sep 23, 2024

FrancoAguzzi reviewed Sep 23, 2024

View reviewed changes

heronlancellot and others added 2 commits September 24, 2024 10:47

Update components/01-atoms/ENSAvatar.tsx

0f9b7ea

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/ENSAvatar.tsx

ef4854e

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

heronlancellot and others added 22 commits September 24, 2024 10:47

Update components/01-atoms/ENSAvatar.tsx

d0b9d78

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/ENSAvatar.tsx

12716a1

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/SearchBar.tsx

5623181

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/SearchBar.tsx

469c6eb

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/SearchBar.tsx

021a569

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/SearchBar.tsx

2441ff8

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/01-atoms/SearchBar.tsx

c169cb1

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/02-molecules/EnsNameAndAddressWallet.tsx

09d5093

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/02-molecules/OfferSummary.tsx

4599dc6

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/02-molecules/TheHeader.tsx

3ee2958

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/02-molecules/UserOfferInfo.tsx

d478d30

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/02-molecules/UserOfferInfo.tsx

8cde85a

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/02-molecules/UserOfferInfo.tsx

dd9fb72

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/02-molecules/UserOfferInfo.tsx

a2993c0

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/02-molecules/UserOfferInfo.tsx

16e14cc

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/02-molecules/UserOfferInfo.tsx

6ab76c3

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

update: SearchBar comments

36de969

update: comments

356585c

update: comments

bec62ed

update: comments

8b510c4

update: comments

8da92a0

update: comments

d79539d

FrancoAguzzi reviewed Sep 24, 2024

View reviewed changes

components/01-atoms/SearchBar.tsx Show resolved Hide resolved

components/02-molecules/EnsNameAndAddressWallet.tsx Outdated Show resolved Hide resolved

update: comments

f659bcd

FrancoAguzzi reviewed Sep 24, 2024

View reviewed changes

heronlancellot and others added 2 commits September 24, 2024 16:08

Update components/01-atoms/SearchBar.tsx

c6edfd2

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Update components/02-molecules/EnsNameAndAddressWallet.tsx

38666df

Co-authored-by: caco.eth <49823133+FrancoAguzzi@users.noreply.github.com>

Conversation

heronlancellot commented Sep 19, 2024

Uh oh!

vercel bot commented Sep 19, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants