Open
Conversation
Bumps [parser](https://github.com/whitequark/parser) from 3.3.3.0 to 3.3.4.0. - [Changelog](https://github.com/whitequark/parser/blob/master/CHANGELOG.md) - [Commits](whitequark/parser@v3.3.3.0...v3.3.4.0) --- updated-dependencies: - dependency-name: parser dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.64.1 to 1.65.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](rubocop/rubocop@v1.64.1...v1.65.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: indirect update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [ember-cli](https://github.com/ember-cli/ember-cli) from 5.9.0 to 5.10.0. - [Release notes](https://github.com/ember-cli/ember-cli/releases) - [Changelog](https://github.com/ember-cli/ember-cli/blob/master/CHANGELOG.md) - [Commits](ember-cli/ember-cli@v5.9.0...v5.10.0) --- updated-dependencies: - dependency-name: ember-cli dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…course#27824) Bumps [@json-editor/json-editor](https://github.com/json-editor/json-editor) from 2.10.0 to 2.15.1. - [Changelog](https://github.com/json-editor/json-editor/blob/master/CHANGELOG.md) - [Commits](json-editor/json-editor@2.10.0...2.15.1) --- updated-dependencies: - dependency-name: "@json-editor/json-editor" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…and sort both lists alphabetically (unlocks discourse#27781)
Bumps [faraday](https://github.com/lostisland/faraday) from 2.9.2 to 2.10.0. - [Release notes](https://github.com/lostisland/faraday/releases) - [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md) - [Commits](lostisland/faraday@v2.9.2...v2.10.0) --- updated-dependencies: - dependency-name: faraday dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Not used anywhere
Internal ref t/132745
Co-authored-by: Jarek Radosz <jarek@cvx.dev>
Co-authored-by: Jarek Radosz <jradosz@gmail.com>
Bumps [terser](https://github.com/terser/terser) from 5.31.1 to 5.31.2. - [Changelog](https://github.com/terser/terser/blob/master/CHANGELOG.md) - [Commits](terser/terser@v5.31.1...v5.31.2) --- updated-dependencies: - dependency-name: terser dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This commit adds the missing title for notifications-button. In the past, it was automatically fallbacked to the button's key. Related meta topic: https://meta.discourse.org/t/tracking-toggle-text-on-hover-sometimes-not-translated/315727
… item (discourse#27775) During migration of Poll plugin from widget basis to glimmer, some functionality was inadvertently dropped: - A single button should appear instead of the dropdown menu when there is only one valid "poll admin" action - No button should appear when there are no valid "poll admin" actions for current user This PR restores the original behaviour and adds test coverage (that didn't exist prior to migration, partly why it wasn't caught earlier) relates to discourse#27204 related meta topic: https://meta.discourse.org/t/what-is-the-gear-button-under-the-poll-for/315477/2
Both office365 and outlook SMTP servers need LOGIN SMTP authentication instead of PLAIN (which is what we are using by default). This commit uses that unconditionally for these servers, and also makes sure to use STARTTLS for them too.
discourse#27855) This commit improves the logging of Sidekiq errors when `ENABLE_LOGSTASH_LOGGER` is set to 1. Prior to this change, we would only log the message and the backtrace. After this change, useful information like `job.class`, `job.opts`, `job.problem_db`, `exception.class` and `exception.message` are included in the log line as well.
Currently, when a plugin registers a new reviewable type or extends a list method (through `register_reviewble_type` and `extend_list_method` respectively), the new array is statically computed and always returns the same value. It will continue to return the same value even if the plugin is disabled (it can be a problem in a multisite env too). To address this issue, this patch changes how `extend_list_method` works. It’s now using `DiscoursePluginRegistry.define_filtered_register` to create a register on the fly and store the extra values from various plugins. It then combines the original values with the ones from the registry. The registry is already aware of disabled plugins, so when a plugin is disabled, its registered values won’t be returned.
- set in constructor so they're guaranteed to be present, even if async-import hasn't finished yet - ensure they're all cleaned up properly - combine two cleanup methods into one
Internal ref t/132507
Form Kit is our new form library/framework for unifying the way forms look across Discourse. The admin config area for the /about page is a new form that isn't currently used, so it makes sense for it to be one of the first forms to be migrated to Form Kit to test the library. Co-authored-by: Joffrey JAFFEUX <j.jaffeux@gmail.com>
Regressed in discourse#28047 Should fix issue reported in https://meta.discourse.org/t/broken-password-confirmation-box-on-registration/318386
…se#28063) We were displaying the "outputs HTML" option in all watched word actions, while it's only supposed to be used in the Replace action.
…#28068)" (discourse#28086) This reverts commit 5dca68d. Pending evilmartians/lefthook#783
When we show user tips, we immediately send an AJAX request to mark the tiup as seen. This is done in the background. However, when system tests are run, sometimes that request is not completed before the test ends. This causes the test to be flakey. One way to fix this is to force the system test run to wait for the AJAX request to complete. However, this is not ideal because it makes the test suite slower on each run. Instead, this commit removes the flakey assertion and adds an alternative assertion in the frontend tests that ensures the background request is sent when the user tip is shown.
* UX: Fix button syntax in preferences * linting
Currently, when adding translation overrides, values aren’t validated for MF strings. This results in being able to add invalid plural keys or even strings containing invalid syntax. This patch addresses this issue by compiling the string when saving an override if the key is detected as an MF one. If there’s an error from the compiler, it’s added to the model errors, which in turn is displayed to the user in the admin UI, helping them to understand what went wrong.
Bumps [docile](https://github.com/ms-ati/docile) from 1.4.0 to 1.4.1. - [Changelog](https://github.com/ms-ati/docile/blob/main/HISTORY.md) - [Commits](ms-ati/docile@v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: docile dependency-type: indirect update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…urse#28092) Bumps [ember-test-selectors](https://github.com/mainmatter/ember-test-selectors) from 6.0.0 to 7.0.0. - [Release notes](https://github.com/mainmatter/ember-test-selectors/releases) - [Changelog](https://github.com/mainmatter/ember-test-selectors/blob/master/CHANGELOG.md) - [Commits](mainmatter/ember-test-selectors@v6.0.0...v7.0.0) --- updated-dependencies: - dependency-name: ember-test-selectors dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The message grace edit window (10 seconds) was too short after freezing time, possibly causing the test to fail occasionally if the record is not updated within 5 seconds.
This patch fixes the `i18n:check` rake task which has been broken by the `MessageFormat` upgrade. It also adds a spec to ensure we generate valid MF code for all our available locales.
By default, the swc minifier seems to unwrap 'unneeded' IIFE. That means it was undoing the 'bugfix' transformation we have for class fields in Safari 15. Disabling the 'inline' and 'reduce_funcs' options seems to stop this behavior.
…se#28091) Bumps [puppeteer-core](https://github.com/puppeteer/puppeteer) from 22.13.0 to 22.14.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json) - [Commits](puppeteer/puppeteer@puppeteer-core-v22.13.0...puppeteer-core-v22.14.0) --- updated-dependencies: - dependency-name: puppeteer-core dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
July 2024 edition
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.16.6 to 1.16.7. - [Release notes](https://github.com/sparklemotion/nokogiri/releases) - [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md) - [Commits](sparklemotion/nokogiri@v1.16.6...v1.16.7) --- updated-dependencies: - dependency-name: nokogiri dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@swc/core](https://github.com/swc-project/swc) from 1.7.0 to 1.7.3. - [Release notes](https://github.com/swc-project/swc/releases) - [Changelog](https://github.com/swc-project/swc/blob/main/CHANGELOG.md) - [Commits](swc-project/swc@v1.7.0...v1.7.3) --- updated-dependencies: - dependency-name: "@swc/core" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [sanitize](https://github.com/rgrove/sanitize) from 6.1.1 to 6.1.2. - [Release notes](https://github.com/rgrove/sanitize/releases) - [Changelog](https://github.com/rgrove/sanitize/blob/main/HISTORY.md) - [Commits](rgrove/sanitize@v6.1.1...v6.1.2) --- updated-dependencies: - dependency-name: sanitize dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [lefthook](https://github.com/evilmartians/lefthook) from 1.7.5 to 1.7.9. - [Release notes](https://github.com/evilmartians/lefthook/releases) - [Changelog](https://github.com/evilmartians/lefthook/blob/master/CHANGELOG.md) - [Commits](evilmartians/lefthook@v1.7.5...v1.7.9) --- updated-dependencies: - dependency-name: lefthook dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Display new features grouped by month and show additional information about the version.
…28013) We want to change the design of the "member experience" step of the wizard from using checkbox switches to using radio toggle groups.
…course#28037) * FIX: Ensure JsLocaleHelper to obly outputs up-to-date translations The old implementation forgot to filter out deprecated translations, causing these translations to incorrectly override the new locale in the frontend. This commit fills in the forgotten where clause, filtering only the up-to-date part. Related meta topic: https://meta.discourse.org/t/outdated-translation-replacement-causing-missing-translation/314352
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.