-
Notifications
You must be signed in to change notification settings - Fork 23
Ut uc #285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: blp_dev
Are you sure you want to change the base?
Ut uc #285
Changes from all commits
9dcca39
efab2c5
95f4df0
2d95a4a
e11b47c
c7767e1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -197,7 +197,7 @@ def enqueue_creation(current_controller) | |
| puts "user-auto-creation : save the user_creation info" | ||
|
|
||
| blp_user_info = build_blp_user_info | ||
| blp_user_info.save | ||
| blp_user_info.save if blp_user_info.uuid | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What's the impact if blp_user_info is not saved to the db?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If the user creation doesn't have the record during the creation, the user creation fails for bloomberg flow. From the tests, the carto flow should be good. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we add additional unit tests for the Bloomberg flow?
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. short answer is 'yes'. I will take it up as a next filler item. |
||
|
|
||
| puts "user-auto-creation : saved the blp_user_info" | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What will happen if @organization is null (ie: if subdomain is null?)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an invalid scenario for us, since we always need to have the global scenario, the other flow is for carto. @organization is setup in both flows, bloomberg vs non-bloomberg, so it should always be there.