Contained

[ben-e-james]

@swift-student

[swift-student]

Hey Ben, excellent job getting everything hooked up with the tab bar and multiple storyboards. I did notice your settings weren't hooked up to the controls in storyboard, but after hooking them up (and swapping them), they work great! Keep up the good work!

[swift-student]

These are swapped (oops) and not actually hooked up to the storyboard. Fixing that, it works great!

[ben-e-james]

Oh dang, yeah I originally put the settings in the info SB on the last screen and when I realized my error and put them in the right place I forgot to hook them up, my bad!

…

On Thu, Jun 4, 2020 at 7:50 PM swift-student ***@***.***> wrote: ***@***.**** commented on this pull request. Hey Ben, excellent job getting everything hooked up with the tab bar and multiple storyboards. I did notice your settings weren't hooked up to the controls in storyboard, but after hooking them up (and swapping them), they work great! Keep up the good work! ------------------------------ In Contained/Contained/Files/SettingsViewController.swift <#224 (comment)> : > + @IBAction func toggleZoom(_ sender: UISwitch) { + Settings.shared.shouldRoll = sender.isOn + } + + @IBAction func toggleRoll(_ sender: UISwitch) { + Settings.shared.shouldZoom = sender.isOn + } These are swapped (oops) and not actually hooked up to the storyboard. Fixing that, it works great! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#224 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/APLWC2L4JI624GQU4NC6CRTRVBMQBANCNFSM4NSJBVIQ> .