[iOS2] Pull request for daily project#3
Open
jasonmodisett17 wants to merge 9 commits intobloominstituteoftechnology:masterfrom
jasonmodisett17:master
Open
[iOS2] Pull request for daily project#3jasonmodisett17 wants to merge 9 commits intobloominstituteoftechnology:masterfrom jasonmodisett17:master
jasonmodisett17 wants to merge 9 commits intobloominstituteoftechnology:masterfrom
jasonmodisett17:master
Conversation
added 9 commits
August 30, 2018 15:50
|
Nice job Jason! Everything works well and great spacing in between functions & properties. Glad we were able to figure out the issue with the Tabbar item. Since I'm in both our group and Josephs channel, I can tell you almost everyone tripped up on that one. But one thing I would encourage (this is very nitpicky) you to do is organize your files in different groups such as Model, Model Controller, View Controller, Views, Resources, etc. This is just a suggestion. Trust me, it will help you especially when your codebase gets very large. Anyways, overall... A+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lpuentes19 @jasonmodisett17