Moin Uddin - Poll Project#4
Open
Legitcoder wants to merge 1 commit intobloominstituteoftechnology:masterfrom
Open
Moin Uddin - Poll Project#4Legitcoder wants to merge 1 commit intobloominstituteoftechnology:masterfrom
Legitcoder wants to merge 1 commit intobloominstituteoftechnology:masterfrom
Conversation
|
Moin! So the project built and the functionality was there. Great job! All objectives were met. I do have some suggestions to help organize and clean your code. I would suggest grouping your files into folders. For example, Models, View Controllers, Views, Resources, etc. Also, please make sure that you're committing more often. That's what Git is used for and it's very helpful whenever you make a mistake somewhere and want to revert back to your last commit. Other than that, good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lpuentes19