Farhan F - Poll Project#8
Open
farhanf wants to merge 2 commits intobloominstituteoftechnology:masterfrom
farhanf:master
Open
Farhan F - Poll Project#8farhanf wants to merge 2 commits intobloominstituteoftechnology:masterfrom farhanf:master
farhanf wants to merge 2 commits intobloominstituteoftechnology:masterfrom
farhanf:master
Conversation
|
Farhan, great job on this project! It looks great and runs fine. All objectives were met. I would just like to suggest a couple things to help your code look cleaner and more organized. I recommend throwing your files in groups. This can be folders called Models, Views, View Controllers, Resources, etc. Also, look for and delete any commented code you don't need. This will help your files look sharp. Lastly, make sure to add commits more often. Usually, you separate them by functionality. Like I said, these our suggestions. Your code looked great and the project functions like it was supposed to. Good work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lpuentes19