Bugfix/forge 486 preview token support #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a227cec)
(cherry picked from commit 19bcd9f)
Add support for bypassing IP filtering when a preview-token query parameter is present in the request. This resolves CLIENT-1046 where preview URLs were being blocked by the IP filter. Implementation Details: - Add CONFIG_PREVIEW_TOKEN_ENABLED and PREVIEW_TOKEN_PARAM_NAME constants - Add previewTokenEnabled field to AuthObject for configuration - Load preview-token-enabled boolean from JCR configuration (defaults to false) - Check for preview-token query parameter in isIgnored() method - If enabled and token is present, bypass IP filtering with debug logging - Change isIgnored() visibility to protected for testability Testing: - Added 4 comprehensive unit tests covering all scenarios: - Preview token bypasses filter when enabled - Preview token is ignored when disabled - Missing token does not bypass filter - Empty token does not bypass filter - All existing tests pass (8 total) Fixes: FORGE-486, CLIENT-1046 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.