Move metrics folder from nested within exporters folder#2
Draft
BrandenRice wants to merge 7 commits intomainfrom
Draft
Move metrics folder from nested within exporters folder#2BrandenRice wants to merge 7 commits intomainfrom
BrandenRice wants to merge 7 commits intomainfrom
Conversation
added 7 commits
February 9, 2024 10:59
Add ENV VAR configuration for config folder locations. Update prometheus metrics to produce lowercase type values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates a few things:
metricsare provided in a nested folder inexporters, which provides challenges when creating nested directory structures as volume mounts in k8s. The metrics config discovery process works the same in the Java code as it did before, but themetricsandexportersfolders are now completely separate.resources/exporters/metrics. An environment variable can now be provided for the exporter and metrics directory paths, with the default path pointing to the examples provided within the source code. This is key to allow users to define their own rules without modifying the source code.COUNT,GAUGE). These have been converted to lowercase in the prometheus exporter, as well as in the tests.