Fix md5srv binary web.post handling and improve CI observability#235
Merged
haydenroche5 merged 1 commit intomasterfrom Mar 8, 2026
Merged
Fix md5srv binary web.post handling and improve CI observability#235haydenroche5 merged 1 commit intomasterfrom
haydenroche5 merged 1 commit intomasterfrom
Conversation
- Fix md5srv.py to handle requests using Transfer-Encoding: chunked instead of Content-Length. Notehub sends binary web.post payloads chunked, causing post_data to read 0 bytes and write_file to return 400 "Request body is empty." - Fix write_file to fall back to len(self.post_data) when the Content-Length header is absent, rather than calling int(None) and crashing with a 500. - Add error logging to md5srv.py: on any failed request, log the Content-Length, Transfer-Encoding, and Content-Type headers along with the error code and message to aid future debugging. - Capture Notecard USB trace output (req, comm, sync, mem) to trace.log during the test run and upload it as a CI artifact. - Upload md5srv.log as a CI artifact so server-side failures are visible without needing to reproduce locally. Commit message written by Claude.
zfields
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit message written by Claude.