Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the JSON schema validation flow and payload handling for Notecard by updating schema caching, error formatting, and CLI flag/environment variable handling. Key changes include:
- Refactoring schema functions to include a verbose flag for logging and enhanced error messages.
- Updating main CLI logic to remove the deprecated force flag and integrate JSON schema control via environment variables.
- Removing JSON schema configuration from the config module.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| notecard/validate.go | Updated schema fetching, caching, and validation functions with verbose logging and improved error formatting. |
| notecard/main.go | Modified CLI handling for JSON schema validation and payload merging; removed deprecated flags. |
| lib/config.go | Removed JSON schema configuration flags and related properties. |
Comments suppressed due to low confidence (1)
notecard/main.go:150
- [nitpick] The environment variable 'BLUES' is ambiguous; consider renaming it to something more descriptive like 'ENABLE_JSON_VALIDATION' for clarity.
_, validateJSON = os.LookupEnv("BLUES")
zfields
approved these changes
May 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.