Skip to content

Zak payload modified#39

Merged
rayozzie merged 10 commits intomasterfrom
zak-payload-modified
May 4, 2025
Merged

Zak payload modified#39
rayozzie merged 10 commits intomasterfrom
zak-payload-modified

Conversation

@rayozzie
Copy link
Copy Markdown
Contributor

@rayozzie rayozzie commented May 4, 2025

No description provided.

@zfields zfields requested a review from Copilot May 4, 2025 17:25
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the JSON schema validation flow and payload handling for Notecard by updating schema caching, error formatting, and CLI flag/environment variable handling. Key changes include:

  • Refactoring schema functions to include a verbose flag for logging and enhanced error messages.
  • Updating main CLI logic to remove the deprecated force flag and integrate JSON schema control via environment variables.
  • Removing JSON schema configuration from the config module.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
notecard/validate.go Updated schema fetching, caching, and validation functions with verbose logging and improved error formatting.
notecard/main.go Modified CLI handling for JSON schema validation and payload merging; removed deprecated flags.
lib/config.go Removed JSON schema configuration flags and related properties.
Comments suppressed due to low confidence (1)

notecard/main.go:150

  • [nitpick] The environment variable 'BLUES' is ambiguous; consider renaming it to something more descriptive like 'ENABLE_JSON_VALIDATION' for clarity.
_, validateJSON = os.LookupEnv("BLUES")

Comment thread notecard/validate.go
@rayozzie rayozzie merged commit 91475ec into master May 4, 2025
1 check passed
@rayozzie rayozzie deleted the zak-payload-modified branch May 4, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants