Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a SEGFAULT issue by adding a nil check before an error is dereferenced, improves error message clarity for unknown requests, and adds a launch.json file for CLI debugging.
- Adds a nil check in formatErrorMessage to prevent a nil-pointer dereference.
- Updates resolveSchemaError to improve error message readability and to handle unknown request types by checking file existence.
Files not reviewed (1)
- .vscode/launch.json: Language not supported
Also, improves error message readability for unknown request
zfields
commented
May 7, 2025
Notecard API is case sensitive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nilcheck on error before dereferencelaunch.jsonfor debuggingnotecardandnotehubCLIs