Skip to content

fix: handle segfault on missing input data #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Bucknalla merged 1 commit into from
Aug 7, 2025
Merged

fix: handle segfault on missing input data #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions notecard/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,20 +773,24 @@ func main() {
}
}
} else if err == nil && req.Req == "card.binary.put" && (req.Body == nil || len(*req.Body) == 0) {
payload := *req.Payload
actualMD5 := fmt.Sprintf("%x", md5.Sum(payload))
if req.Status != "" && !strings.EqualFold(req.Status, actualMD5) {
err = fmt.Errorf("actual MD5 %s != supplied 'status' field %s", actualMD5, req.Status)
if req.Payload == nil {
err = fmt.Errorf("card.binary.put requires payload data")
} else {
req.Status = actualMD5
payload, err = notecard.CobsEncode(payload, byte('\n'))
if err == nil {
req.Payload = nil
req.Cobs = int32(len(payload))
rsp, err = card.TransactionRequest(req)
payload := *req.Payload
actualMD5 := fmt.Sprintf("%x", md5.Sum(payload))
if req.Status != "" && !strings.EqualFold(req.Status, actualMD5) {
err = fmt.Errorf("actual MD5 %s != supplied 'status' field %s", actualMD5, req.Status)
} else {
req.Status = actualMD5
payload, err = notecard.CobsEncode(payload, byte('\n'))
if err == nil {
payload = append(payload, byte('\n'))
err = card.SendBytes(payload)
req.Payload = nil
req.Cobs = int32(len(payload))
rsp, err = card.TransactionRequest(req)
if err == nil {
payload = append(payload, byte('\n'))
err = card.SendBytes(payload)
}
}
}
}
Expand Down