stripe api. prefix before making call to noteboard#55
stripe api. prefix before making call to noteboard#55scottfrazer wants to merge 1 commit intomasterfrom
Conversation
rayozzie
left a comment
rayozzie
left a comment
There was a problem hiding this comment.
Scott, I just got off with Kevin and i don't think this will work, and i think there is a better way all around. Please do connect with him as I will be on a plane tomorrow. In a nutshell,
- because "hub" == config.Hub == "api.notefile.net" in the default case, this statement will end up doing a NewRequest to "https://notefile.net/userinfo"
- unless I'm mistaken, noteboard/app2/controller/echo.go serves the introspection endpoint on "notehub.io/userinfo", which is most certainly not notefile.net
Compounded with the fact that I do not want .io domains hard-wired into any code, I think the best overall solution is to quickly deploy a simple piece of code in notehub that serves up a new /userinfo endpoint on api.notefile.net which internally does nothing but an HTTP redirect to https://notehub.io/userinfo
If you do this, it will mean that you can just close this PR and both the hub/note-go/notehub/auth.go code and the note-cli/lib/config.go code will work unchanged, and it satisfies my ".io" requirement by having the notehub.io reference somewhere that we can control and even redeploy if necessary.
|
okay will do |
2 participants
No description provided.