Conversation
zfields
requested changes
Oct 6, 2025
zfields
reviewed
Oct 8, 2025
Co-authored-by: Zachary J. Fields <zachary_fields@yahoo.com>
Co-authored-by: Zachary J. Fields <zachary_fields@yahoo.com>
Co-authored-by: Zachary J. Fields <zachary_fields@yahoo.com>
Co-authored-by: Zachary J. Fields <zachary_fields@yahoo.com>
Co-authored-by: Zachary J. Fields <zachary_fields@yahoo.com>
Co-authored-by: Zachary J. Fields <zachary_fields@yahoo.com>
zfields
approved these changes
Oct 8, 2025
| //============================================================================= | ||
|
|
||
| #ifdef CONFIG_NOTECARD_I2C_MUTEX | ||
| static void notecard_platform_lock_i2c(void) |
Contributor
There was a problem hiding this comment.
Suggested change
| static void notecard_platform_lock_i2c(void) | |
| static void notecard_platform_i2c_lock(void) |
| } | ||
| } | ||
|
|
||
| static void notecard_platform_unlock_i2c(void) |
Contributor
There was a problem hiding this comment.
Suggested change
| static void notecard_platform_unlock_i2c(void) | |
| static void notecard_platform_i2c_unlock(void) |
| } | ||
| #endif | ||
|
|
||
| static void notecard_platform_lock_note(void) |
Contributor
There was a problem hiding this comment.
Suggested change
| static void notecard_platform_lock_note(void) | |
| static void notecard_platform_note_lock(void) |
| } | ||
| } | ||
|
|
||
| static void notecard_platform_unlock_note(void) |
Contributor
There was a problem hiding this comment.
Suggested change
| static void notecard_platform_unlock_note(void) | |
| static void notecard_platform_note_unlock(void) |
Comment on lines
+497
to
+498
| NoteSetFnNoteMutex(notecard_platform_lock_note, | ||
| notecard_platform_unlock_note); |
Contributor
There was a problem hiding this comment.
Suggested change
| NoteSetFnNoteMutex(notecard_platform_lock_note, | |
| notecard_platform_unlock_note); | |
| NoteSetFnNoteMutex(notecard_platform_note_lock, | |
| notecard_platform_note_unlock); |
Comment on lines
+502
to
+503
| NoteSetFnI2CMutex(notecard_platform_lock_i2c, | ||
| notecard_platform_unlock_i2c); |
Contributor
There was a problem hiding this comment.
Suggested change
| NoteSetFnI2CMutex(notecard_platform_lock_i2c, | |
| notecard_platform_unlock_i2c); | |
| NoteSetFnI2CMutex(notecard_platform_i2c_lock, | |
| notecard_platform_i2c_unlock); |
| #ifdef CONFIG_NOTECARD_I2C_MUTEX | ||
| void notecard_i2c_lock(void) | ||
| { | ||
| notecard_platform_lock_i2c(); |
Contributor
There was a problem hiding this comment.
Suggested change
| notecard_platform_lock_i2c(); | |
| notecard_platform_i2c_lock(); |
|
|
||
| void notecard_i2c_unlock(void) | ||
| { | ||
| notecard_platform_unlock_i2c(); |
Contributor
There was a problem hiding this comment.
Suggested change
| notecard_platform_unlock_i2c(); | |
| notecard_platform_i2c_unlock(); |
Co-authored-by: Zachary J. Fields <zachary_fields@yahoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.