Conversation
…or handling, type safety - Refactor analytics.ts to use shared apiFetch/apiGet/apiPost helpers instead of duplicating fetchAuthSession + raw fetch in every function (~150 lines removed) - Consolidate useIsAdmin, useUserGroups, useCanSendCommands onto a single shared TanStack Query cache entry to eliminate redundant Cognito round-trips - Fix DisplayPreferences and FleetDefaults to only clear hasChanges on mutation onSuccess callback, preventing silent save button disable on API failure - Add error feedback UI to both settings components on mutation failure - Fix catch (error: any) in Analytics.tsx with proper TypeScript narrowing - Replace index-based chat message keys with stable type+timestamp identity - Tighten QueryResult.data from any[] to QueryRow[] (Record<string, string|number|boolean|null>[]) - Fix missing Satellite import in DeviceDetail.tsx Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tracing.ts Reduces CloudWatch log volume in production by gating "Creating span", "Span completed successfully", "Span ended", and flush lifecycle logs behind DEBUG_TRACING=true. console.error calls are kept unconditionally. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…vLogConfigChanges serial port Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…r + react-query refactors - Merge origin/main to pull in the test suite from #18; resolve DeviceDetail.tsx import conflict (keep Satellite icon added here). - Rewrite analytics.test.ts to mock the ./client helpers (apiFetch/apiGet/apiPost/apiPut/apiPatch/apiDelete) instead of the old global fetch + fetchAuthSession pattern, matching analytics.ts's refactor to call those helpers. - Wrap useAuth hook tests in a QueryClientProvider and disable retry/ retryDelay on the test QueryClient, since useAuth now backs its hooks with @tanstack/react-query. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
…-bugs # Conflicts: # songbird-dashboard/src/components/settings/FleetDefaults.tsx # songbird-dashboard/src/pages/DeviceDetail.tsx
…-bugs # Conflicts: # songbird-dashboard/src/api/analytics.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
audioPlayMelodywas callingvTaskDelayunconditionally between notes, including when called fromsetup()before the FreeRTOS scheduler starts — callingvTaskDelaypre-scheduler is undefined behavior (likely hard fault on STM32). Applied the sameuseRtosPrimitives()guard already used byaudioPlayTone.elapsed < TRIPLE_CLICK_TIMEOUT_MScreated a window where a double-click arriving near the timeout boundary was silently dropped (fell through to the orphan reset). Removed the upper bound — triple-click is already handled by theclickCount >= 3branch above.envLogConfigChangeswas callingSerialdirectly instead ofDEBUG_SERIALand had no#ifdef DEBUG_MODEguard — meaning it ran in production builds and may have outputted to the wrong UART. Now consistent withenvLogConfig.Test plan
pio run)🤖 Generated with Claude Code