Conversation
…eedback endpoint, restrict device auth Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Merge origin/main to pick up the test suite from #18, then update the 3 GET /analytics/feedback tests to include cognito:groups=Admin in the authorizer JWT claims, matching the admin-group check this PR adds to the handler. Also adds a new test covering the 403 denial path. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aws-marketplace:Subscribefrom chat query Lambda IAM role — this permission allows subscribing to paid Marketplace products and should never be in a Lambda execution role; also scopebedrock:InvokeModelto specific model ARNsMath.random()alert ID generation withcrypto.randomUUID()— eliminates collision risk at high throughput, uses built-in Node 20 crypto moduleACKNOWLEDGEDconstant ('true'/'false'strings) to shared module — prevents accidental boolean writes that would break the GSI querymarshallOptions: { removeUndefinedValues: true }to DynamoDB clients inapi-alertsandapi-devices— matches the pattern already used inapi-ingestand prevents latent runtime errors on optional fieldsTest plan
cd songbird-infrastructure && npx cdk synth)🤖 Generated with Claude Code