Skip to content

Pass required to cast_embed/3 not validate_required/3 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thetamind wants to merge 1 commit into
base: reorg
Choose a base branch
from
Open

Pass required to cast_embed/3 not validate_required/3 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions apps/blunt/lib/blunt/message/changeset.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,11 @@ defmodule Blunt.Message.Changeset do

changeset =
embeds
|> Enum.reduce(changeset, &Changeset.cast_embed(&2, &1, with: embed_changeset))
|> Changeset.validate_required(required_fields)
|> Enum.reduce(
changeset,
&Changeset.cast_embed(&2, &1, with: embed_changeset, required: &1 in required_fields)
)
|> Changeset.validate_required(required_fields -- embeds)
|> run_built_in_validations(message_module)
|> message_module.handle_validate(opts)

Expand Down
22 changes: 22 additions & 0 deletions apps/blunt/test/blunt/message/changeset_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,28 @@ defmodule Blunt.Message.ChangesetTest do
assert true = Keyword.get(opts, :test_option)
end

describe "embedded field" do
defmodule EmbedsManyCommand do
use Blunt.Command
field :one, EmbeddedMessage
field :many, {:array, EmbeddedMessage}
field :optionals, {:array, EmbeddedMessage}, required: false
end

test "passes required option to cast_embed/3 not validate_required/3" do
refute ExUnit.CaptureIO.capture_io(:stderr, fn ->
assert {:ok, %EmbedsManyCommand{one: %EmbeddedMessage{}, many: [%EmbeddedMessage{}, %EmbeddedMessage{}]}} =
EmbedsManyCommand.new(%{one: %{}, many: [%{}, %{}]})
end) =~
~r/attempting to validate embed_many field :many/
end

test "errors when blank" do
assert {:error, %{many: ["can't be blank"], one: ["can't be blank"]}} =
EmbedsManyCommand.new(%{one: nil, many: [], optionals: [%{}]})
end
end

describe "autogenerated id field" do
defmodule WithAutoId do
use Blunt.Command
Expand Down